Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: lib/compiler/implementation/native_emitter.dart

Issue 10310060: Generate getters and setters dynamically. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/native_emitter.dart
diff --git a/lib/compiler/implementation/native_emitter.dart b/lib/compiler/implementation/native_emitter.dart
index c38dc23e7502496373cbf17c761898c0eca4de8a..cf88e261cc886440e2258757ee858e0fc2e6527e 100644
--- a/lib/compiler/implementation/native_emitter.dart
+++ b/lib/compiler/implementation/native_emitter.dart
@@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
class NativeEmitter {
+ final emptyElementSet;
kasperl 2012/05/09 07:53:15 Add a comment here that explains what this is used
ngeoffray 2012/05/09 08:50:28 final Set<Element>
floitsch 2012/05/09 13:58:36 Done.
floitsch 2012/05/09 13:58:36 removed.
Compiler compiler;
StringBuffer nativeBuffer;
@@ -37,7 +38,8 @@ class NativeEmitter {
directSubtypes = new Map<ClassElement, List<ClassElement>>(),
overriddenMethods = new Set<FunctionElement>(),
nativeMethods = new Set<FunctionElement>(),
- nativeBuffer = new StringBuffer();
+ nativeBuffer = new StringBuffer(),
+ emptyElementSet = new Set<Element>();
String get dynamicName() {
Element element = compiler.findHelper(
@@ -84,7 +86,8 @@ class NativeEmitter {
for (Element member in classElement.members) {
if (member.isInstanceMember()) {
- compiler.emitter.addInstanceMember(member, defineInstanceMember);
+ compiler.emitter.addInstanceMember(
+ member, emptyElementSet, defineInstanceMember);
}
}
}
@@ -129,7 +132,8 @@ class NativeEmitter {
for (Element member in classElement.members) {
if (member.isInstanceMember()) {
- compiler.emitter.addInstanceMember(member, defineInstanceMember);
+ compiler.emitter.addInstanceMember(
+ member, emptyElementSet, defineInstanceMember);
}
}
« lib/compiler/implementation/namer.dart ('K') | « lib/compiler/implementation/namer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698