Generate getters and setters dynamically.

lib/compiler/implementation/native_emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class NativeEmitter {
+  final emptyElementSet;

[kasperl, 2012/05/09 07:53:15]

Add a comment here that explains what this is used for. It seems a bit wonky.

[ngeoffray, 2012/05/09 08:50:28]

final Set<Element>

[floitsch, 2012/05/09 13:58:36]

Done.

[floitsch, 2012/05/09 13:58:36]

removed.

 
   Compiler compiler;
   StringBuffer nativeBuffer;
 
   // Classes that participate in dynamic dispatch. These are the
   // classes that contain used members.
   Set<ClassElement> classesWithDynamicDispatch;
 
   // Native classes found in the application.
   Set<ClassElement> nativeClasses;
@@ skipping 14 matching lines @@
   // implementation.
   Set<FunctionElement> nativeMethods;
 
   NativeEmitter(this.compiler)
       : classesWithDynamicDispatch = new Set<ClassElement>(),
         nativeClasses = new Set<ClassElement>(),
         subtypes = new Map<ClassElement, List<ClassElement>>(),
         directSubtypes = new Map<ClassElement, List<ClassElement>>(),
         overriddenMethods = new Set<FunctionElement>(),
         nativeMethods = new Set<FunctionElement>(),
-        nativeBuffer = new StringBuffer();
+        nativeBuffer = new StringBuffer(),
+        emptyElementSet = new Set<Element>();
 
   String get dynamicName() {
     Element element = compiler.findHelper(
         const SourceString('dynamicFunction'));
     return compiler.namer.isolateAccess(element);
   }
 
   String get dynamicSetMetadataName() {
     Element element = compiler.findHelper(
         const SourceString('dynamicSetMetadata'));
@@ skipping 26 matching lines @@
     nativeBuffer.add(' = ');
     nativeBuffer.add(nativeCode);
     nativeBuffer.add(';\n');
 
     void defineInstanceMember(String name, String value) {
       nativeBuffer.add("$className.$name = $value;\n");
     }
 
     for (Element member in classElement.members) {
       if (member.isInstanceMember()) {
-        compiler.emitter.addInstanceMember(member, defineInstanceMember);
+        compiler.emitter.addInstanceMember(
+            member, emptyElementSet, defineInstanceMember);
       }
     }
   }
 
   bool isNativeLiteral(String quotedName) {
     return quotedName[1] === '=';
   }
 
   bool isNativeGlobal(String quotedName) {
     return quotedName[1] === '@';
@@ skipping 24 matching lines @@
     String nativeName = toNativeName(classElement);
     bool hasUsedSelectors = false;
 
     void defineInstanceMember(String name, String value) {
       hasUsedSelectors = true;
       nativeBuffer.add("$dynamicName('$name').$nativeName = $value;\n");
     }
 
     for (Element member in classElement.members) {
       if (member.isInstanceMember()) {
-        compiler.emitter.addInstanceMember(member, defineInstanceMember);
+        compiler.emitter.addInstanceMember(
+            member, emptyElementSet, defineInstanceMember);
       }
     }
 
     compiler.emitter.generateTypeTests(classElement, (Element other) {
       assert(requiresNativeIsCheck(other));
       defineInstanceMember(compiler.namer.operatorIs(other),
                            "function() { return true; }");
     });
 
     if (hasUsedSelectors) classesWithDynamicDispatch.add(classElement);
@@ skipping 228 matching lines @@
     String toStringName = compiler.namer.instanceMethodName(
         null, const SourceString('toString'), 0);
     objectProperties.add("$defPropName(Object.prototype, '$toStringName', ");
     objectProperties.add(
         'function() { return $toStringHelperName(this); });\n');
 
     // Finally, emit the code in the main buffer.
     targetBuffer.add('(function() {\n$objectProperties$nativeBuffer\n})();\n');
   }
 }