Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: chrome/browser/net/connection_tester_unittest.cc

Issue 10299002: Stop refcounting URLRequestContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initialize to NULL Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/connection_tester.cc ('k') | chrome/browser/net/http_pipelining_compatibility_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/connection_tester_unittest.cc
diff --git a/chrome/browser/net/connection_tester_unittest.cc b/chrome/browser/net/connection_tester_unittest.cc
index 3ecfa489c154aa3f868d0c5129482bbdf7c97c5a..6dd99b36907f21468c273f2cf0595863a8e8eb96 100644
--- a/chrome/browser/net/connection_tester_unittest.cc
+++ b/chrome/browser/net/connection_tester_unittest.cc
@@ -113,8 +113,8 @@ class ConnectionTesterTest : public PlatformTest {
scoped_refptr<net::SSLConfigService> ssl_config_service_;
scoped_ptr<net::HttpTransactionFactory> http_transaction_factory_;
net::HttpAuthHandlerRegistryFactory http_auth_handler_factory_;
- scoped_refptr<net::URLRequestContext> proxy_script_fetcher_context_;
net::HttpServerPropertiesImpl http_server_properties_impl_;
+ scoped_ptr<net::URLRequestContext> proxy_script_fetcher_context_;
private:
void InitializeRequestContext() {
@@ -148,7 +148,7 @@ class ConnectionTesterTest : public PlatformTest {
TEST_F(ConnectionTesterTest, RunAllTests) {
ASSERT_TRUE(test_server_.Start());
- ConnectionTester tester(&test_delegate_, proxy_script_fetcher_context_);
+ ConnectionTester tester(&test_delegate_, proxy_script_fetcher_context_.get());
// Start the test suite on URL "echoall".
// TODO(eroman): Is this URL right?
@@ -173,7 +173,8 @@ TEST_F(ConnectionTesterTest, DeleteWhileInProgress) {
ASSERT_TRUE(test_server_.Start());
scoped_ptr<ConnectionTester> tester(
- new ConnectionTester(&test_delegate_, proxy_script_fetcher_context_));
+ new ConnectionTester(&test_delegate_,
+ proxy_script_fetcher_context_.get()));
// Start the test suite on URL "echoall".
// TODO(eroman): Is this URL right?
« no previous file with comments | « chrome/browser/net/connection_tester.cc ('k') | chrome/browser/net/http_pipelining_compatibility_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698