Stop refcounting URLRequestContext.

chrome/browser/net/connection_tester_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/connection_tester.h"
 
 #include "chrome/test/base/testing_pref_service.h"
 #include "content/test/test_browser_thread.h"
 #include "net/base/mock_cert_verifier.h"
 #include "net/base/mock_host_resolver.h"
@@ skipping 95 matching lines @@
   MessageLoop message_loop_;
   content::TestBrowserThread io_thread_;
   net::TestServer test_server_;
   ConnectionTesterDelegate test_delegate_;
   net::MockHostResolver host_resolver_;
   scoped_ptr<net::CertVerifier> cert_verifier_;
   scoped_ptr<net::ProxyService> proxy_service_;
   scoped_refptr<net::SSLConfigService> ssl_config_service_;
   scoped_ptr<net::HttpTransactionFactory> http_transaction_factory_;
   net::HttpAuthHandlerRegistryFactory http_auth_handler_factory_;
-  scoped_refptr<net::URLRequestContext> proxy_script_fetcher_context_;
   net::HttpServerPropertiesImpl http_server_properties_impl_;
+  scoped_ptr<net::URLRequestContext> proxy_script_fetcher_context_;
 
  private:
   void InitializeRequestContext() {
     proxy_script_fetcher_context_->set_host_resolver(&host_resolver_);
     cert_verifier_.reset(new net::MockCertVerifier);
     proxy_script_fetcher_context_->set_cert_verifier(cert_verifier_.get());
     proxy_script_fetcher_context_->set_http_auth_handler_factory(
         &http_auth_handler_factory_);
     proxy_service_.reset(net::ProxyService::CreateDirect());
     proxy_script_fetcher_context_->set_proxy_service(proxy_service_.get());
@@ skipping 13 matching lines @@
         http_transaction_factory_.get());
     // In-memory cookie store.
     proxy_script_fetcher_context_->set_cookie_store(
         new net::CookieMonster(NULL, NULL));
   }
 };
 
 TEST_F(ConnectionTesterTest, RunAllTests) {
   ASSERT_TRUE(test_server_.Start());
 
-  ConnectionTester tester(&test_delegate_, proxy_script_fetcher_context_);
+  ConnectionTester tester(&test_delegate_, proxy_script_fetcher_context_.get());
 
   // Start the test suite on URL "echoall".
   // TODO(eroman): Is this URL right?
   tester.RunAllTests(test_server_.GetURL("echoall"));
 
   // Wait for all the tests to complete.
   MessageLoop::current()->Run();
 
   const int kNumExperiments =
       ConnectionTester::PROXY_EXPERIMENT_COUNT *
       ConnectionTester::HOST_RESOLVER_EXPERIMENT_COUNT;
 
   EXPECT_EQ(1, test_delegate_.start_connection_test_suite_count());
   EXPECT_EQ(kNumExperiments,
             test_delegate_.start_connection_test_experiment_count());
   EXPECT_EQ(kNumExperiments,
             test_delegate_.completed_connection_test_experiment_count());
   EXPECT_EQ(1, test_delegate_.completed_connection_test_suite_count());
 }
 
 TEST_F(ConnectionTesterTest, DeleteWhileInProgress) {
   ASSERT_TRUE(test_server_.Start());
 
   scoped_ptr<ConnectionTester> tester(
-      new ConnectionTester(&test_delegate_, proxy_script_fetcher_context_));
+      new ConnectionTester(&test_delegate_,
+                           proxy_script_fetcher_context_.get()));
 
   // Start the test suite on URL "echoall".
   // TODO(eroman): Is this URL right?
   tester->RunAllTests(test_server_.GetURL("echoall"));
 
   // Don't run the message loop at all.  Otherwise the experiment's request may
   // complete and post a task to run the next experiment before we quit the
   // message loop.
 
   EXPECT_EQ(1, test_delegate_.start_connection_test_suite_count());
@@ skipping 10 matching lines @@
   // any pending tasks instead of running them. This causes a problem with
   // net::ClientSocketPoolBaseHelper, since the "Group" holds a pointer
   // |backup_task| that it will try to deref during the destructor, but
   // depending on the order that pending tasks were deleted in, it might
   // already be invalid! See http://crbug.com/43291.
   MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
   MessageLoop::current()->Run();
 }
 
 }  // namespace