Issue 10284006: Adding an icon specifying mime-type="image/vnd.microsoft.icon" for https://chromiumcodereview.appsp…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10284006: Adding an icon specifying mime-type="image/vnd.microsoft.icon" for https://chromiumcodereview.appsp… (Closed)

Created:
8 years, 7 months ago by alexeypa (please no reviews)

Modified:
8 years, 7 months ago

Reviewers:
simonmorris

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Adding an icon specifying mime-type="image/vnd.microsoft.icon" for https://chromiumcodereview.appspot.com/10266024/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134941

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	A	remoting/resources/chromoting.ico	View		Binary file		0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

Checking an icon separately via SVN so that I can specify its mime-type.

8 years, 7 months ago (2012-05-01 23:45:39 UTC) #1

simonmorris

On 2012/05/01 23:45:39, alexeypa wrote: > Checking an icon separately via SVN so that I ...

8 years, 7 months ago (2012-05-01 23:48:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10284006/1

8 years, 7 months ago (2012-05-01 23:57:30 UTC) #4

commit-bot: I haz the power

8 years, 7 months ago (2012-05-01 23:57:34 UTC) #5

Failed to request the patch to try. Please note that binary filesare still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 302: Found

Expand Messages | Collapse Messages