Make the PIN confirmation dialog an ATL-based one and brushing it up a little bit.

Make the PIN confirmation dialog an ATL-based one and brushing it up a little bit.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134965

[alexeypa (please no reviews), 2012-05-01 18:03:19]

PTAL

[simonmorris, 2012-05-01 18:17:52]

On 2012/05/01 18:03:19, alexeypa wrote:
> PTAL

LGTM with optional suggestions.

[simonmorris, 2012-05-01 18:25:45]

lgtm with optional suggestions.

http://codereview.chromium.org/10266024/diff/1/remoting/host/verify_config_wi...
File remoting/host/verify_config_window_win.cc (right):

http://codereview.chromium.org/10266024/diff/1/remoting/host/verify_config_wi...
remoting/host/verify_config_window_win.cc:113: }
Or just "x = std::min(x, area_rect.right - width);", as the previous line?

http://codereview.chromium.org/10266024/diff/1/remoting/host/verify_config_wi...
remoting/host/verify_config_window_win.cc:117: }
Same suggestion.

[alexeypa (please no reviews), 2012-05-01 18:30:08]

FYI.

http://codereview.chromium.org/10266024/diff/1/remoting/host/verify_config_wi...
File remoting/host/verify_config_window_win.cc (right):

http://codereview.chromium.org/10266024/diff/1/remoting/host/verify_config_wi...
remoting/host/verify_config_window_win.cc:113: }
On 2012/05/01 18:25:45, simonmorris wrote:
> Or just "x = std::min(x, area_rect.right - width);", as the previous line?

Done.

http://codereview.chromium.org/10266024/diff/1/remoting/host/verify_config_wi...
remoting/host/verify_config_window_win.cc:117: }
On 2012/05/01 18:25:45, simonmorris wrote:
> Same suggestion.

Done.

[commit-bot: I haz the power, 2012-05-01 23:03:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10266024/9001

[commit-bot: I haz the power, 2012-05-01 23:03:56]

Presubmit check for 10266024-9001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Run the command: svn pset svn:mime-type image/vnd.microsoft.icon \
  remoting/resources/chromoting.ico

Presubmit checks took 10.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-05-02 17:45:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10266024/18001

[commit-bot: I haz the power, 2012-05-02 19:33:51]

Change committed as 134965