Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 10271010: Merge r11471 from the bleeding_edge to the 3.8 branch. (Closed)

Created:
8 years, 7 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Merge r11471 from the bleeding_edge to the 3.8 branch. Don't ignore return value of CommitCodePage in AllocateAlignedMemory. Release the mapping as whole if commit failed to avoid leaking virtual address space. R=mstarzinger@chromium.org BUG=chromium:118625 Review URL: https://chromiumcodereview.appspot.com/10260012 ------------------------------------------------------------------------ Committed: https://code.google.com/p/v8/source/detail?r=11477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M src/spaces.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/spaces.cc View 1 chunk +12 lines, -5 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 7 months ago (2012-04-30 16:03:15 UTC) #1
Michael Starzinger
8 years, 7 months ago (2012-04-30 16:29:08 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698