Issue 10260012: Don't ignore return value of CommitCodePage in AllocateAlignedMemory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10260012: Don't ignore return value of CommitCodePage in AllocateAlignedMemory. (Closed)

Created:
8 years, 7 months ago by Vyacheslav Egorov (Chromium)

Modified:
8 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Don't ignore return value of CommitCodePage in AllocateAlignedMemory. Release the mapping as whole if commit failed to avoid leaking virtual address space. R=mstarzinger@chromium.org BUG=chromium:118625 Committed: https://code.google.com/p/v8/source/detail?r=11471

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
	M	src/spaces.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	src/spaces.cc	View		1 chunk	+12 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM.