Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 10264023: Revert 134625 - Transmit a X-Chrome-UMA-Enabled bit to Google domains from clients that have UMA en… (Closed)

Created:
8 years, 7 months ago by kkania
Modified:
8 years, 7 months ago
Reviewers:
SteveT
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 134625 - Transmit a X-Chrome-UMA-Enabled bit to Google domains from clients that have UMA enabled. Causing startup crash on Linux chromeos bot. This requires a change to the ChromeNetworkDelegate where we feed the incognito state (a bool) into the object at creation time, so we can check that field when doing our header setting. BUG=123609 TEST=With UMA enabled (not Chromium), visit www.google.com and ensure that the request header includes X-Chrome-UMA-Enabled with value "1". Ensure that disabling UMA also disables the transmission of this header entirely. Also, ensure that unit_tests GoogleUtilTests all pass. TBR=ivankr@chromium.org Review URL: http://codereview.chromium.org/10108026 TBR=stevet@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -142 lines) Patch
M chrome/browser/google/google_util.h View 1 chunk +2 lines, -15 lines 0 comments Download
M chrome/browser/google/google_util.cc View 3 chunks +12 lines, -16 lines 0 comments Download
M chrome/browser/google/google_util_unittest.cc View 2 chunks +0 lines, -49 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 5 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/protector/protector_service.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kkania
8 years, 7 months ago (2012-04-30 23:49:55 UTC) #1
kkania
AutomatedUITestBase.CloseTab: [1710:1710:70893511:WARNING:zygote_host_impl_linux.cc(154)] Running without the SUID sandbox! See http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with ...
8 years, 7 months ago (2012-04-30 23:50:46 UTC) #2
SteveT
8 years, 7 months ago (2012-05-01 14:58:10 UTC) #3
lgtm - thanks for reverting.

I've figured out the issue and will reland with a fix today. Thanks!

Powered by Google App Engine
This is Rietveld 408576698