Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

Issue 10264023: Revert 134625 - Transmit a X-Chrome-UMA-Enabled bit to Google domains from clients that have UMA en… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
===================================================================
--- chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc (revision 134639)
+++ chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc (working copy)
@@ -12,7 +12,6 @@
#include "chrome/browser/download/download_util.h"
#include "chrome/browser/extensions/user_script_listener.h"
#include "chrome/browser/external_protocol/external_protocol_handler.h"
-#include "chrome/browser/google/google_util.h"
#include "chrome/browser/instant/instant_loader.h"
#include "chrome/browser/net/load_timing_observer.h"
#include "chrome/browser/prerender/prerender_manager.h"
@@ -164,8 +163,6 @@
#endif
}
- AppendChromeMetricsHeaders(request, resource_context, resource_type);
-
AppendStandardResourceThrottles(request,
resource_context,
child_id,
@@ -296,28 +293,6 @@
throttles->push_back(throttle);
}
-void ChromeResourceDispatcherHostDelegate::AppendChromeMetricsHeaders(
- net::URLRequest* request,
- content::ResourceContext* resource_context,
- ResourceType::Type resource_type) {
- // Note our criteria for attaching Chrome experiment headers:
- // 1. We only transmit to *.google.<TLD> domains. NOTE that this use of
- // google_util helpers to check this does not guarantee that the URL is
- // Google-owned, only that it is of the form *.google.<TLD>. In the future
- // we may choose to reinforce this check.
- // 2. We only transmit for non-Incognito profiles.
- // 3. For the X-Chrome-UMA-Enabled bit, we only set it if UMA is in fact
- // enabled for this install of Chrome.
- ProfileIOData* io_data = ProfileIOData::FromResourceContext(resource_context);
- if (google_util::IsGoogleDomainUrl(request->url().spec(),
- google_util::ALLOW_SUBDOMAIN) &&
- !io_data->is_incognito() && io_data->enable_metrics()->GetValue()) {
- request->SetExtraRequestHeaderByName("X-Chrome-UMA-Enabled",
- "1",
- false);
- }
-}
-
bool ChromeResourceDispatcherHostDelegate::ShouldForceDownloadResource(
const GURL& url, const std::string& mime_type) {
// Special-case user scripts to get downloaded instead of viewed.

Powered by Google App Engine
This is Rietveld 408576698