DescriptionWindowed mode mouse lock addded to fullscreen controller.
Allows mouse lock to be entered outside of fullscreen.
The root changes are in
chrome/browser/ui/fullscreen_controller
They require the user interface bubble to be more tolerant of state changes. Three versions of that code are modified:
Views:
chrome/browser/ui/views/frame/browser_view.cc
GTK:
chrome/browser/ui/gtk/browser_window_gtk.cc
Mac:
chrome/browser/ui/cocoa/...
Testing is expanded in:
chrome/browser/ui/browser_browsertest.cc
BUG=107013
TEST=Entering and exiting of mouse lock and fullscreen. chrome/test/data/fullscreen_mouselock/fullscreen_mouselock.html
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138150
Patch Set 1 : . #
Total comments: 30
Patch Set 2 : yzshen feedback addressed. #
Total comments: 10
Patch Set 3 : Nits addressed. #Patch Set 4 : Fix Mac build bot errors #
Total comments: 8
Patch Set 5 : Notifications not delayed, documented; merged to lkgr #Patch Set 6 : indent #Messages
Total messages: 13 (0 generated)
|