Policy tweaks to address syscall failures seen in 20.0.115.1

Policy tweaks to address syscall failures seen in 20.0.115.1

BUG=125635
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134626

[Chris Evans, 2012-04-30 22:54:45]

(Anyone can give a quick review so I can hit the deadline for the next dev
channel?)

Trying to get towards completing phase 1: get the policy stable such that
failure crashes are just noise.

[Kees Cook, 2012-04-30 22:57:27]

lgtm

[Jorge Lucangeli Obes, 2012-04-30 22:59:18]

lgtm

[Chris Evans, 2012-04-30 23:04:05]

On 2012/04/30 22:59:18, Jorge Lucangeli Obes wrote:
> lgtm

Thanks Kees / Jorge. Once tomorrow's dev channel is out, I'll send out a summary
of where stability stands.

[jln (very slow on Chromium), 2012-04-30 23:44:29]

https://chromiumcodereview.appspot.com/10260024/diff/2002/content/common/sand...
File content/common/sandbox_init_linux.cc (right):

https://chromiumcodereview.appspot.com/10260024/diff/2002/content/common/sand...
content/common/sandbox_init_linux.cc:255: EmitAllowSyscall(__NR_gettimeofday,
program);
This still misses sigreturn and restart_syscall

[Markus (顧孟勤), 2012-04-30 23:52:10]

And of course, on 32bit you need both sigreturn and rt_sigreturn

On Mon, Apr 30, 2012 at 16:44, <jln@chromium.org> wrote:

>
> https://chromiumcodereview.**appspot.com/10260024/diff/**
>
2002/content/common/sandbox_**init_linux.cc<https://chromiumcodereview.appspot.com/10260024/diff/2002/content/common/sandbox_init_linux.cc>
> File content/common/sandbox_init_**linux.cc (right):
>
> https://chromiumcodereview.**appspot.com/10260024/diff/**
>
2002/content/common/sandbox_**init_linux.cc#newcode255<https://chromiumcodereview.appspot.com/10260024/diff/2002/content/common/sandbox_init_linux.cc#newcode255>
> content/common/sandbox_init_**linux.cc:255:
> EmitAllowSyscall(__NR_**gettimeofday, program);
> This still misses sigreturn and restart_syscall
>
>
https://chromiumcodereview.**appspot.com/10260024/<https://chromiumcodereview...
>

[cevans, 2012-05-01 02:40:32]

On Mon, Apr 30, 2012 at 5:44 PM, <jln@chromium.org> wrote:

>
> https://chromiumcodereview.**appspot.com/10260024/diff/**
>
2002/content/common/sandbox_**init_linux.cc<https://chromiumcodereview.appspot.com/10260024/diff/2002/content/common/sandbox_init_linux.cc>
> File content/common/sandbox_init_**linux.cc (right):
>
> https://chromiumcodereview.**appspot.com/10260024/diff/**
>
2002/content/common/sandbox_**init_linux.cc#newcode255<https://chromiumcodereview.appspot.com/10260024/diff/2002/content/common/sandbox_init_linux.cc#newcode255>
> content/common/sandbox_init_**linux.cc:255:
> EmitAllowSyscall(__NR_**gettimeofday, program);
> This still misses sigreturn and restart_syscall
>

Thanks. I'll add them in a follow-up CL. For now, I'm mainly trying to get
the policy stable "in the field". Once achieved, there will be furious
effort towards making it pretty :)


>
>
https://chromiumcodereview.**appspot.com/10260024/<https://chromiumcodereview...
>