Policy tweaks to address syscall failures seen in 20.0.115.1

content/common/sandbox_init_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/sandbox_init.h"
 
 #if defined(OS_LINUX) && defined(__x86_64__)
 
 #include <asm/unistd.h>
 #include <errno.h>
@@ skipping 181 matching lines @@
   EmitAllowSyscall(__NR_read, program);
   EmitAllowSyscall(__NR_ioctl, program);
   EmitAllowSyscall(__NR_poll, program);
   EmitAllowSyscall(__NR_epoll_wait, program);
   EmitAllowSyscall(__NR_recvfrom, program);
   EmitAllowSyscall(__NR_write, program);
   EmitAllowSyscall(__NR_writev, program);
   EmitAllowSyscall(__NR_gettid, program);
 
   // Less hot syscalls.
+  EmitAllowSyscall(__NR_clock_gettime, program);
   EmitAllowSyscall(__NR_futex, program);
   EmitAllowSyscall(__NR_madvise, program);
   EmitAllowSyscall(__NR_sendmsg, program);
   EmitAllowSyscall(__NR_recvmsg, program);
   EmitAllowSyscall(__NR_eventfd2, program);
   EmitAllowSyscall(__NR_pipe, program);
   EmitAllowSyscall(__NR_mmap, program);
   EmitAllowSyscall(__NR_mprotect, program);
   EmitAllowSyscall(__NR_clone, program);
   EmitAllowSyscall(__NR_set_robust_list, program);
@@ skipping 15 matching lines @@
   EmitAllowSyscall(__NR_munmap, program);
   EmitAllowSyscall(__NR_dup, program);
   EmitAllowSyscall(__NR_mlock, program);
   EmitAllowSyscall(__NR_munlock, program);
   EmitAllowSyscall(__NR_exit, program);
   EmitAllowSyscall(__NR_exit_group, program);
   EmitAllowSyscall(__NR_getpid, program);  // Seen in Nvidia binary driver.
   EmitAllowSyscall(__NR_getppid, program);  // Seen in ATI binary driver.
   EmitAllowKillSelf(SIGTERM, program);  // GPU watchdog.
 
+  // Generally, filename-based syscalls will fail with ENOENT to behave
+  // similarly to a possible future setuid sandbox.
   EmitFailSyscall(__NR_open, ENOENT, program);
   EmitFailSyscall(__NR_access, ENOENT, program);
+  EmitFailSyscall(__NR_mkdir, ENOENT, program);  // Nvidia binary driver.
+  EmitFailSyscall(__NR_readlink, ENOENT, program);  // ATI binary driver.
 }
 
 static void ApplyFlashPolicy(std::vector<struct sock_filter>* program) {
   // "Hot" syscalls go first.
   EmitAllowSyscall(__NR_futex, program);
   EmitAllowSyscall(__NR_write, program);
   EmitAllowSyscall(__NR_epoll_wait, program);
   EmitAllowSyscall(__NR_read, program);
   EmitAllowSyscall(__NR_times, program);
 
   // Less hot syscalls.
+  EmitAllowSyscall(__NR_gettimeofday, program);

[jln (very slow on Chromium), 2012/04/30 23:44:29]

This still misses sigreturn and restart_syscall

   EmitAllowSyscall(__NR_clone, program);
   EmitAllowSyscall(__NR_set_robust_list, program);
   EmitAllowSyscall(__NR_getuid, program);
   EmitAllowSyscall(__NR_geteuid, program);
   EmitAllowSyscall(__NR_getgid, program);
   EmitAllowSyscall(__NR_getegid, program);
   EmitAllowSyscall(__NR_epoll_create, program);
   EmitAllowSyscall(__NR_fcntl, program);
   EmitAllowSyscall(__NR_socketpair, program);
   EmitAllowSyscall(__NR_pipe, program);
@@ skipping 92 matching lines @@
 
 namespace content {
 
 void InitializeSandbox() {
 }
 
 }  // namespace content
 
 #endif