Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/spaces.h

Issue 10260012: Don't ignore return value of CommitCodePage in AllocateAlignedMemory. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/spaces.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1024 matching lines...) Expand 10 before | Expand all | Expand 10 after
1035 static int CodePageGuardSize(); 1035 static int CodePageGuardSize();
1036 1036
1037 static int CodePageAreaStartOffset(); 1037 static int CodePageAreaStartOffset();
1038 1038
1039 static int CodePageAreaEndOffset(); 1039 static int CodePageAreaEndOffset();
1040 1040
1041 static int CodePageAreaSize() { 1041 static int CodePageAreaSize() {
1042 return CodePageAreaEndOffset() - CodePageAreaStartOffset(); 1042 return CodePageAreaEndOffset() - CodePageAreaStartOffset();
1043 } 1043 }
1044 1044
1045 static bool CommitCodePage(VirtualMemory* vm, Address start, size_t size); 1045 MUST_USE_RESULT static bool CommitCodePage(VirtualMemory* vm,
1046 Address start,
1047 size_t size);
1046 1048
1047 private: 1049 private:
1048 Isolate* isolate_; 1050 Isolate* isolate_;
1049 1051
1050 // Maximum space size in bytes. 1052 // Maximum space size in bytes.
1051 size_t capacity_; 1053 size_t capacity_;
1052 // Maximum subset of capacity_ that can be executable 1054 // Maximum subset of capacity_ that can be executable
1053 size_t capacity_executable_; 1055 size_t capacity_executable_;
1054 1056
1055 // Allocated space size in bytes. 1057 // Allocated space size in bytes.
(...skipping 1583 matching lines...) Expand 10 before | Expand all | Expand 10 after
2639 } 2641 }
2640 // Must be small, since an iteration is used for lookup. 2642 // Must be small, since an iteration is used for lookup.
2641 static const int kMaxComments = 64; 2643 static const int kMaxComments = 64;
2642 }; 2644 };
2643 #endif 2645 #endif
2644 2646
2645 2647
2646 } } // namespace v8::internal 2648 } } // namespace v8::internal
2647 2649
2648 #endif // V8_SPACES_H_ 2650 #endif // V8_SPACES_H_
OLDNEW
« no previous file with comments | « no previous file | src/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698