Move Declarative Web Request API out of experimental and make it a feature

Move Declarative Web Request API out of experimental and make it a feature

This CL moves the declarative web request API and the declarative API out of the experimental namespace. Instead the APIs become features that are only enabled on the dev channel.

This CL introduces also empty permissions for the APIs, we need to improve this so that host permissions are respected.

BUG=112155
TEST=no

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136006

[battre, 2012-04-27 15:40:18]

aa: this is the discussed change, to move the declarative webrequest api out of
the experimental namespace and make it a feature available only on the dev
branch. Do you like the "declarativeWebRequest" namespace or should this become
"declarative.webRequest"? In the latter case we would probably need to modify
the permission system. I think it considers only the permission string up to the
first ".".

Please review in case the try bots are already happy.

mpcomplete: FYI

Thanks,
Dominic

[battre, 2012-05-02 12:50:29]

friendly ping

[Aaron Boodman, 2012-05-03 18:10:15]

lgtm

http://codereview.chromium.org/10257006/diff/1/chrome/common/extensions/api/_...
File chrome/common/extensions/api/_permission_features.json (right):

http://codereview.chromium.org/10257006/diff/1/chrome/common/extensions/api/_...
chrome/common/extensions/api/_permission_features.json:76: "declarative": {
Can you put a TODO in here like:

TODO(battre): Remove "declarative" permission when APIs can be set to dev-only,
without having to have a permission. See: crbug.com/120069.

[battre, 2012-05-07 14:28:30]

http://codereview.chromium.org/10257006/diff/1/chrome/common/extensions/api/_...
File chrome/common/extensions/api/_permission_features.json (right):

http://codereview.chromium.org/10257006/diff/1/chrome/common/extensions/api/_...
chrome/common/extensions/api/_permission_features.json:76: "declarative": {
On 2012/05/03 18:10:16, Aaron Boodman wrote:
> Can you put a TODO in here like:
> 
> TODO(battre): Remove "declarative" permission when APIs can be set to
dev-only,
> without having to have a permission. See: crbug.com/120069.

Done.

[commit-bot: I haz the power, 2012-05-08 09:33:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10257006/17002

[commit-bot: I haz the power, 2012-05-08 10:00:52]

Try job failure for 10257006-17002 on win for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-05-08 11:35:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10257006/17002

[commit-bot: I haz the power, 2012-05-08 14:20:07]

Try job failure for 10257006-17002 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-08 16:50:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10257006/17002

[commit-bot: I haz the power, 2012-05-08 20:03:21]

Try job failure for 10257006-17002 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...