Issue 10254005: ia32: Redefine register usage in LoadIC/KeyedLoadIC to match StoreIC and KeyedStoreIC

Issue 10254005: ia32: Redefine register usage in LoadIC/KeyedLoadIC to match StoreIC and KeyedStoreIC (Closed)

Created:
8 years, 8 months ago by Jakob Kummerow

Modified:
8 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ia32: Redefine register usage in LoadIC/KeyedLoadIC to match StoreIC and KeyedStoreIC Committed: https://code.google.com/p/v8/source/detail?r=11460

Patch Set 2 : addressed comments; removed debug code #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -213 lines)			Patch
M	src/ia32/builtins-ia32.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/ia32/debug-ia32.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1	11 chunks	+25 lines, -16 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1	23 chunks	+78 lines, -86 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		38 chunks	+83 lines, -95 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with comments. https://chromiumcodereview.appspot.com/10254005/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/10254005/diff/1/src/ia32/full-codegen-ia32.cc#newcode4139 src/ia32/full-codegen-ia32.cc:4139: __ mov(ecx, eax); // Key. This ...

8 years, 8 months ago (2012-04-27 12:47:12 UTC) #2

Jakob Kummerow

8 years, 8 months ago (2012-04-27 13:01:24 UTC) #3

Comments addressed, landing.

https://chromiumcodereview.appspot.com/10254005/diff/1/src/ia32/full-codegen-...
File src/ia32/full-codegen-ia32.cc (right):

https://chromiumcodereview.appspot.com/10254005/diff/1/src/ia32/full-codegen-...
src/ia32/full-codegen-ia32.cc:4139: __ mov(ecx, eax);              // Key.
On 2012/04/27 12:47:12, Yang wrote:
> This is similar to line 1176, except that eax gets overwritten. Why the
> difference?

No reason. Unified.

https://chromiumcodereview.appspot.com/10254005/diff/1/src/ia32/ic-ia32.cc
File src/ia32/ic-ia32.cc (right):

https://chromiumcodereview.appspot.com/10254005/diff/1/src/ia32/ic-ia32.cc#ne...
src/ia32/ic-ia32.cc:525: __ bind(&ok);
On 2012/04/27 12:47:12, Yang wrote:
> Can be shortened with MacroAssembler::Check(Condition cc, const char* msg)

Good point. Done.

Expand Messages | Collapse Messages