Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 10254005: ia32: Redefine register usage in LoadIC/KeyedLoadIC to match StoreIC and KeyedStoreIC (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments; removed debug code Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 // overwritten by the address of DebugBreakXXX. 165 // overwritten by the address of DebugBreakXXX.
166 ExternalReference after_break_target = 166 ExternalReference after_break_target =
167 ExternalReference(Debug_Address::AfterBreakTarget(), masm->isolate()); 167 ExternalReference(Debug_Address::AfterBreakTarget(), masm->isolate());
168 __ jmp(Operand::StaticVariable(after_break_target)); 168 __ jmp(Operand::StaticVariable(after_break_target));
169 } 169 }
170 170
171 171
172 void Debug::GenerateLoadICDebugBreak(MacroAssembler* masm) { 172 void Debug::GenerateLoadICDebugBreak(MacroAssembler* masm) {
173 // Register state for IC load call (from ic-ia32.cc). 173 // Register state for IC load call (from ic-ia32.cc).
174 // ----------- S t a t e ------------- 174 // ----------- S t a t e -------------
175 // -- eax : receiver
176 // -- ecx : name 175 // -- ecx : name
176 // -- edx : receiver
177 // ----------------------------------- 177 // -----------------------------------
178 Generate_DebugBreakCallHelper(masm, eax.bit() | ecx.bit(), 0, false); 178 Generate_DebugBreakCallHelper(masm, ecx.bit() | edx.bit(), 0, false);
179 } 179 }
180 180
181 181
182 void Debug::GenerateStoreICDebugBreak(MacroAssembler* masm) { 182 void Debug::GenerateStoreICDebugBreak(MacroAssembler* masm) {
183 // Register state for IC store call (from ic-ia32.cc). 183 // Register state for IC store call (from ic-ia32.cc).
184 // ----------- S t a t e ------------- 184 // ----------- S t a t e -------------
185 // -- eax : value 185 // -- eax : value
186 // -- ecx : name 186 // -- ecx : name
187 // -- edx : receiver 187 // -- edx : receiver
188 // ----------------------------------- 188 // -----------------------------------
189 Generate_DebugBreakCallHelper( 189 Generate_DebugBreakCallHelper(
190 masm, eax.bit() | ecx.bit() | edx.bit(), 0, false); 190 masm, eax.bit() | ecx.bit() | edx.bit(), 0, false);
191 } 191 }
192 192
193 193
194 void Debug::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 194 void Debug::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
195 // Register state for keyed IC load call (from ic-ia32.cc). 195 // Register state for keyed IC load call (from ic-ia32.cc).
196 // ----------- S t a t e ------------- 196 // ----------- S t a t e -------------
197 // -- ecx : key
197 // -- edx : receiver 198 // -- edx : receiver
198 // -- eax : key
199 // ----------------------------------- 199 // -----------------------------------
200 Generate_DebugBreakCallHelper(masm, eax.bit() | edx.bit(), 0, false); 200 Generate_DebugBreakCallHelper(masm, ecx.bit() | edx.bit(), 0, false);
201 } 201 }
202 202
203 203
204 void Debug::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 204 void Debug::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
205 // Register state for keyed IC load call (from ic-ia32.cc). 205 // Register state for keyed IC load call (from ic-ia32.cc).
206 // ----------- S t a t e ------------- 206 // ----------- S t a t e -------------
207 // -- eax : value 207 // -- eax : value
208 // -- ecx : key 208 // -- ecx : key
209 // -- edx : receiver 209 // -- edx : receiver
210 // ----------------------------------- 210 // -----------------------------------
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 326
327 const bool Debug::kFrameDropperSupported = true; 327 const bool Debug::kFrameDropperSupported = true;
328 328
329 #undef __ 329 #undef __
330 330
331 #endif // ENABLE_DEBUGGER_SUPPORT 331 #endif // ENABLE_DEBUGGER_SUPPORT
332 332
333 } } // namespace v8::internal 333 } } // namespace v8::internal
334 334
335 #endif // V8_TARGET_ARCH_IA32 335 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698