Issue 10227009: NOTREACHED() in VarTracker::ReleaseVar() can be reached. Remove it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10227009: NOTREACHED() in VarTracker::ReleaseVar() can be reached. Remove it. (Closed)

Created:
8 years, 8 months ago by Tom Sepez

Modified:
8 years, 8 months ago

Reviewers:
brettw

CC:
chromium-reviews, vtl, yzshen1

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

NOTREACHED() in VarTracker::ReleaseVar() can be reached. Remove it. Because PPB_Var_Deprecated_Proxy::OnMsgReleaseObject() can defer a ReleaseVar() call past the time an instance is destroyed, and because as part of instance destruction HostVarTracker::ForceReleaseNPObject() forcibly zeroes a variable's ref_count and deletes it, the deferred ReleaseVar() call will hit this path frequently and blow up the debugger. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133968

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	ppapi/shared_impl/var_tracker.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages