Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ppapi/shared_impl/var_tracker.cc

Issue 10227009: NOTREACHED() in VarTracker::ReleaseVar() can be reached. Remove it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/var_tracker.cc
===================================================================
--- ppapi/shared_impl/var_tracker.cc (revision 133940)
+++ ppapi/shared_impl/var_tracker.cc (working copy)
@@ -94,10 +94,8 @@
DLOG_IF(ERROR, !CheckIdType(var_id, PP_ID_TYPE_VAR))
<< var_id << " is not a PP_Var ID.";
VarMap::iterator found = live_vars_.find(var_id);
- if (found == live_vars_.end()) {
- NOTREACHED() << "Unref-ing an invalid var";
+ if (found == live_vars_.end())
return false;
- }
VarInfo& info = found->second;
if (info.ref_count == 0) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698