Alarm resolution changed to minutes and minimum delay added.

tools/json_schema_compiler/cc_generator.py

Index: tools/json_schema_compiler/cc_generator.py
diff --git a/tools/json_schema_compiler/cc_generator.py b/tools/json_schema_compiler/cc_generator.py
index af81b5ab3a2750ca6b8fa186fced692e5a0a69d4..a79276ff7c54baaa23f8bc107c63519fce84d0ef 100644
--- a/tools/json_schema_compiler/cc_generator.py
+++ b/tools/json_schema_compiler/cc_generator.py
@@ -453,12 +453,6 @@ class CCGenerator(object):
     c = Code()
     c.Sblock('{')
 
-    if check_type and prop.type_ not in (
-        PropertyType.CHOICES, PropertyType.ANY):
-      (c.Append('if (!%(value_var)s->IsType(%(value_type)s))')
-        .Append('  return %(failure_value)s;')
-      )

[Matt Perry, 2012/04/25 19:11:06]

Why this change?

[Matt Tytel, 2012/04/30 23:36:21]

Ah, I meant to comment on this.
This check is too strict, it causes a problem for TYPE_DOUBLE properties.
Because if you pass a TYPE_INT Value, then this check throws an error because
TYPE_INT != TYPE_DOUBLE. 
We should only check if the passed Value can be converted to the needed Value
which is what the GetAs* functions do below.

[Matt Perry, 2012/04/30 23:51:42]

Makes sense, thanks!

-
     if prop.type_.is_fundamental:
       if prop.optional:
         (c.Append('%(ctype)s temp;')