Alarm resolution changed to minutes and minimum delay added.

tools/json_schema_compiler/cc_generator.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from code import Code
 from model import PropertyType
 import any_helper
 import cpp_util
 import model
 import sys
@@ skipping 435 matching lines @@
     prop: the property the code is populating.
     value_var: a Value* that should represent |prop|.
     dst: the object with |prop| as a member.
     failure_value: the value to return if |prop| cannot be extracted from
     |value_var|
     check_type: if true, will check if |value_var| is the correct Value::Type
     """
     c = Code()
     c.Sblock('{')
 
-    if check_type and prop.type_ not in (
-        PropertyType.CHOICES, PropertyType.ANY):
-      (c.Append('if (!%(value_var)s->IsType(%(value_type)s))')
-        .Append('  return %(failure_value)s;')
-      )

[Matt Perry, 2012/04/25 19:11:06]

Why this change?

[Matt Tytel, 2012/04/30 23:36:21]

Ah, I meant to comment on this.
This check is too strict, it causes a problem for TYPE_DOUBLE properties.
Because if you pass a TYPE_INT Value, then this check throws an error because
TYPE_INT != TYPE_DOUBLE. 
We should only check if the passed Value can be converted to the needed Value
which is what the GetAs* functions do below.

[Matt Perry, 2012/04/30 23:51:42]

Makes sense, thanks!

-
     if prop.type_.is_fundamental:
       if prop.optional:
         (c.Append('%(ctype)s temp;')
           .Append('if (%s)' %
               cpp_util.GetAsFundamentalValue(prop, value_var, '&temp'))
           .Append('  %(dst)s->%(name)s.reset(new %(ctype)s(temp));')
         )
       else:
         (c.Append('if (!%s)' %
             cpp_util.GetAsFundamentalValue(
@@ skipping 176 matching lines @@
     """Determines if this property is an Object or is a ref to an Object.
     """
     return (self._cpp_type_generator.GetReferencedProperty(prop).type_ ==
         PropertyType.OBJECT)
 
   def _IsArrayOrArrayRef(self, prop):
     """Determines if this property is an Array or is a ref to an Array.
     """
     return (self._cpp_type_generator.GetReferencedProperty(prop).type_ ==
         PropertyType.ARRAY)