Issue 10217016: Event page rebranding: "transient" key is now "persistent" again.

Issue 10217016: Event page rebranding: "transient" key is now "persistent" again. (Closed)

Created:
8 years, 8 months ago by Matt Perry

Modified:
8 years, 8 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, pam+watch_chromium.org, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Event page rebranding: "transient" key is now "persistent" again. BUG=no TEST=no Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133947

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -36 lines)			Patch
M	chrome/common/extensions/docs/examples/api/cookies.zip	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp.zip	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/transientPage/basic.zip	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/transientPage/basic/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	3 chunks	+6 lines, -9 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/common/extensions/extension_manifest_constants.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension_manifest_constants.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/browser_action_create_tab/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/browser_action_with_callback/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/incognito_split/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/messaging/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/on_installed/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/on_unload/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/wait_for_request/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/wait_for_view/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10217016/1

8 years, 8 months ago (2012-04-25 00:31:37 UTC) #3

commit-bot: I haz the power

8 years, 8 months ago (2012-04-25 02:07:22 UTC) #4

Can't apply patch for file chrome/common/extensions/docs/samples.json.
While running patch -p1 --forward --force;
patching file chrome/common/extensions/docs/samples.json
Hunk #1 FAILED at 960.
Hunk #2 FAILED at 1085.
Hunk #3 FAILED at 2519.
3 out of 3 hunks FAILED -- saving rejects to file
chrome/common/extensions/docs/samples.json.rej

Expand Messages | Collapse Messages