Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2403)

Unified Diff: chrome/common/extensions/extension.h

Issue 10217016: Event page rebranding: "transient" key is now "persistent" again. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/samples.json ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 764abeea002fff754dd941154a33b28357ad76e2..3e61f835a428aa6a7ee1a558e393885fa328000a 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -603,14 +603,11 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
const std::vector<std::string>& background_scripts() const {
return background_scripts_;
}
- bool background_page_is_transient() const {
- return background_page_is_transient_;
- }
bool has_persistent_background_page() const {
- return has_background_page() && !background_page_is_transient();
+ return has_background_page() && background_page_is_persistent_;
}
bool has_lazy_background_page() const {
- return has_background_page() && background_page_is_transient();
+ return has_background_page() && !background_page_is_persistent_;
}
const GURL& options_url() const { return options_url_; }
const GURL& devtools_url() const { return devtools_url_; }
@@ -765,7 +762,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadBackgroundScripts(string16* error);
bool LoadBackgroundPage(const ExtensionAPIPermissionSet& api_permissions,
string16* error);
- bool LoadBackgroundTransient(
+ bool LoadBackgroundPersistent(
const ExtensionAPIPermissionSet& api_permissions,
string16* error);
bool LoadBackgroundAllowJSAccess(
@@ -958,9 +955,9 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// present, background_url_ will be empty and generated by GetBackgroundURL().
std::vector<std::string> background_scripts_;
- // False if the background page should stay loaded forever; true if it should
- // load on-demand (when it needs to handle an event). Defaults to false.
- bool background_page_is_transient_;
+ // True if the background page should stay loaded forever; false if it should
+ // load on-demand (when it needs to handle an event). Defaults to true.
+ bool background_page_is_persistent_;
// True if the background page can be scripted by pages of the app or
// extension, in which case all such pages must run in the same process.
« no previous file with comments | « chrome/common/extensions/docs/samples.json ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698