Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 10214014: Backport to R19 of r132638 r133017 r133579 r133732 (Closed)

Created:
8 years, 8 months ago by piman
Modified:
8 years, 8 months ago
Reviewers:
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Backport to R19 of r132638 r133017 r133579 r133732 texture_image_transport: have a current context when we're releasing textures In some cases, the TextureImageTransportSurface may get destroyed when no context is current. When that's the case, glDeleteTextures becomes a noop and we leak them. BUG=123933 TEST=manual Review URL: http://codereview.chromium.org/10200012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133732 0039d316-1c4b-4281-b951-d872f2087c98 Unbind texture from all texture units when deleting it. BUG=None TEST=None Review URL: http://codereview.chromium.org/10179006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133579 0039d316-1c4b-4281-b951-d872f2087c98 aura: Add flush() to make sure delete operations make it through when we intend. Resource deletion doesn't force a flush, so for textures that are deleted on a little-used shared context, the delete command may sit in the command buffer for arbitrary long. This fixes it. BUG=123933 TEST=chrome/aura, open many tabs, close all of them, check that GPU memory is reclaimed. Review URL: http://codereview.chromium.org/10078002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133017 0039d316-1c4b-4281-b951-d872f2087c98 Conflicts: content/common/gpu/client/gl_helper.cc aura/texture transport: Keep ref to texture infos to avoid races with the UI In some cases, the UI may destroy the textures the renderer is rendering into before the renderer has a chance to finish. This patch makes it so that we avoid generating a lost context event in the page that is closing, because we can't recover correctly in the other pages in the same renderer process. This also adds logging so that we can audit all cases of lost context. BUG=122868 TEST=run aura chrome, open and close tabs (from the same process), observe no flashing and no mention of a lost context. Review URL: http://codereview.chromium.org/10103021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132638 0039d316-1c4b-4281-b951-d872f2087c98 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -65 lines) Patch
M content/browser/renderer_host/image_transport_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/gl_helper.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.h View 4 chunks +7 lines, -4 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 11 chunks +76 lines, -56 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698