Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10214001: WebDialogs (Closed)

Created:
8 years, 8 months ago by Ben Goodger (Google)
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Web-ify a bunch of these names. I am going to move some of the framework code here down to ui/web_dialogs in a future cl, hence the namespaces. HtmlDialogUI->WebDialogUI HtmlDialogUIDelegate->WebDialogDelegate HtmlDialogTabContentsDelegate->WebDialogWebContentsDelegate HtmlDialogView->WebDialogView HtmlDialogController->WebDialogController HtmlDialogGtk -> WebDialogGtk BUG=none TEST=none TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133991

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+969 lines, -4238 lines) Patch
M chrome/browser/autofill/autofill_feedback_infobar_delegate.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/choose_mobile_network_dialog.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/choose_mobile_network_dialog.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_html_dialog.h View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_html_dialog.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/proxy_settings_dialog.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/sim_dialog_delegate.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/sim_dialog_delegate.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 3 4 5 11 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 1 2 3 4 5 7 chunks +28 lines, -28 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_unittest.cc View 1 2 3 4 5 6 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 2 3 4 5 5 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 5 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 2 3 4 5 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm View 1 2 3 4 5 1 chunk +0 lines, -143 lines 0 comments Download
A + chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 1 2 3 3 chunks +48 lines, -42 lines 0 comments Download
D chrome/browser/ui/cocoa/html_dialog_window_controller.h View 1 2 3 4 5 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/cocoa/html_dialog_window_controller.mm View 1 2 3 4 5 1 chunk +0 lines, -381 lines 0 comments Download
D chrome/browser/ui/cocoa/html_dialog_window_controller_unittest.mm View 1 2 3 4 5 1 chunk +0 lines, -101 lines 0 comments Download
A + chrome/browser/ui/cocoa/web_dialog_window_controller.h View 1 2 3 3 chunks +15 lines, -15 lines 0 comments Download
A + chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 1 2 3 15 chunks +80 lines, -80 lines 0 comments Download
A + chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm View 1 2 3 4 5 6 chunks +13 lines, -13 lines 0 comments Download
D chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc View 1 2 3 4 5 1 chunk +0 lines, -106 lines 0 comments Download
A + chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc View 1 2 3 5 chunks +30 lines, -27 lines 0 comments Download
D chrome/browser/ui/gtk/html_dialog_gtk.h View 1 2 3 4 5 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/ui/gtk/html_dialog_gtk.cc View 1 2 3 4 5 1 chunk +0 lines, -275 lines 0 comments Download
A + chrome/browser/ui/gtk/web_dialog_gtk.h View 1 2 3 4 chunks +18 lines, -18 lines 0 comments Download
A + chrome/browser/ui/gtk/web_dialog_gtk.cc View 1 2 3 11 chunks +51 lines, -51 lines 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/browser/ui/views/constrained_html_delegate_views.cc View 1 2 3 4 5 1 chunk +0 lines, -146 lines 0 comments Download
A + chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 2 3 6 chunks +46 lines, -42 lines 0 comments Download
D chrome/browser/ui/views/html_dialog_view.h View 1 2 3 4 5 1 chunk +0 lines, -145 lines 0 comments Download
D chrome/browser/ui/views/html_dialog_view.cc View 1 2 3 4 5 1 chunk +0 lines, -330 lines 0 comments Download
D chrome/browser/ui/views/html_dialog_view_browsertest.cc View 1 2 3 4 5 1 chunk +0 lines, -208 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_delegate.h View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_delegate.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_dialog_view.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_dialog_view.cc View 1 2 3 4 5 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/web_dialog_view.h View 1 2 3 6 chunks +21 lines, -21 lines 0 comments Download
A + chrome/browser/ui/views/web_dialog_view.cc View 1 2 3 10 chunks +69 lines, -69 lines 0 comments Download
A + chrome/browser/ui/views/web_dialog_view_browsertest.cc View 1 2 3 8 chunks +51 lines, -50 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_ui.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_ui.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 3 4 5 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_dialog.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/ui/webui/constrained_html_ui.h View 1 2 3 4 5 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/ui/webui/constrained_html_ui.cc View 1 2 3 4 5 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/ui/webui/constrained_html_ui_browsertest.cc View 1 2 3 4 5 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/ui/webui/constrained_html_ui_delegate_impl.h View 1 2 3 4 5 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/webui/constrained_html_ui_delegate_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -95 lines 0 comments Download
A + chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 1 2 3 4 2 chunks +26 lines, -21 lines 0 comments Download
A + chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 2 3 4 chunks +26 lines, -26 lines 0 comments Download
A + chrome/browser/ui/webui/constrained_web_dialog_ui.h View 1 2 3 4 3 chunks +25 lines, -25 lines 0 comments Download
A + chrome/browser/ui/webui/constrained_web_dialog_ui.cc View 1 2 3 5 chunks +19 lines, -18 lines 0 comments Download
A + chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 1 2 3 4 chunks +28 lines, -28 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.h View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 1 2 3 4 5 2 chunks +5 lines, -4 lines 0 comments Download
D chrome/browser/ui/webui/html_dialog_controller.h View 1 2 3 4 5 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/ui/webui/html_dialog_controller.cc View 1 2 3 4 5 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/ui/webui/html_dialog_controller_browsertest.cc View 1 2 3 4 5 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h View 1 2 3 4 5 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc View 1 2 3 4 5 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/ui/webui/html_dialog_ui.h View 1 2 3 4 5 1 chunk +0 lines, -175 lines 0 comments Download
D chrome/browser/ui/webui/html_dialog_ui.cc View 1 2 3 4 5 1 chunk +0 lines, -134 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.h View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_dialog.cc View 1 2 3 4 5 6 chunks +11 lines, -11 lines 0 comments Download
D chrome/browser/ui/webui/test_html_dialog_ui_delegate.h View 1 2 3 4 5 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/webui/test_html_dialog_ui_delegate.cc View 1 2 3 4 5 1 chunk +0 lines, -59 lines 0 comments Download
A + chrome/browser/ui/webui/test_web_dialog_delegate.h View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/ui/webui/test_web_dialog_delegate.cc View 1 2 3 2 chunks +12 lines, -12 lines 0 comments Download
A + chrome/browser/ui/webui/web_dialog_controller.h View 1 2 3 2 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/ui/webui/web_dialog_controller.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
A + chrome/browser/ui/webui/web_dialog_controller_browsertest.cc View 1 2 3 2 chunks +14 lines, -15 lines 0 comments Download
A + chrome/browser/ui/webui/web_dialog_ui.h View 1 2 3 6 chunks +16 lines, -16 lines 0 comments Download
A + chrome/browser/ui/webui/web_dialog_ui.cc View 1 2 3 6 chunks +21 lines, -22 lines 0 comments Download
A + chrome/browser/ui/webui/web_dialog_web_contents_delegate.h View 1 2 3 4 chunks +9 lines, -7 lines 0 comments Download
A + chrome/browser/ui/webui/web_dialog_web_contents_delegate.cc View 1 2 3 6 chunks +14 lines, -12 lines 0 comments Download
A + chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc View 1 2 3 3 chunks +30 lines, -30 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 15 chunks +22 lines, -22 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
8 years, 8 months ago (2012-04-25 20:30:13 UTC) #1
tfarina
http://codereview.chromium.org/10214001/diff/15031/chrome/browser/ui/gtk/web_dialog_gtk.h File chrome/browser/ui/gtk/web_dialog_gtk.h (right): http://codereview.chromium.org/10214001/diff/15031/chrome/browser/ui/gtk/web_dialog_gtk.h#newcode71 chrome/browser/ui/gtk/web_dialog_gtk.h:71: // This view is a delegate to the HTML ...
8 years, 8 months ago (2012-04-25 20:38:24 UTC) #2
sky
8 years, 8 months ago (2012-04-25 20:55:31 UTC) #3 
Rubber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698