Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4091)

Unified Diff: chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm

Issue 10214001: WebDialogs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm
===================================================================
--- chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm (revision 133680)
+++ chrome/browser/ui/cocoa/web_dialog_window_controller_unittest.mm (working copy)
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#import "chrome/browser/ui/cocoa/html_dialog_window_controller.h"
+#import "chrome/browser/ui/cocoa/web_dialog_window_controller.h"
#include <string>
#include <vector>
@@ -14,7 +14,7 @@
#include "base/utf_string_conversions.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
-#include "chrome/browser/ui/webui/html_dialog_ui.h"
+#include "chrome/browser/ui/webui/web_dialog_ui.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/browser/web_ui.h"
@@ -29,7 +29,7 @@
namespace {
-class MockDelegate : public HtmlDialogUIDelegate {
+class MockDelegate : public WebDialogDelegate {
public:
MOCK_CONST_METHOD0(GetDialogModalType, ui::ModalType());
MOCK_CONST_METHOD0(GetDialogTitle, string16());
@@ -44,7 +44,7 @@
MOCK_CONST_METHOD0(ShouldShowDialogTitle, bool());
};
-class HtmlDialogWindowControllerTest : public BrowserWithTestWindowTest {
+class WebDialogWindowControllerTest : public BrowserWithTestWindowTest {
public:
virtual void SetUp() {
BrowserWithTestWindowTest::SetUp();
@@ -71,8 +71,8 @@
// In particular, GetWebUIMessageHandlers() and GetDialogArgs() are never
// called. This should be fixed.
-TEST_F(HtmlDialogWindowControllerTest, showDialog) {
- // We want to make sure html_dialog_window_controller below gets
+TEST_F(WebDialogWindowControllerTest, showDialog) {
+ // We want to make sure web_dialog_window_controller below gets
// destroyed before delegate_, so we specify our own autorelease pool.
//
// TODO(dmaclach): Remove this once
@@ -88,14 +88,14 @@
EXPECT_CALL(delegate_, OnDialogClosed(_))
.Times(1);
- HtmlDialogWindowController* html_dialog_window_controller =
- [[HtmlDialogWindowController alloc] initWithDelegate:&delegate_
- profile:profile()
- browser:browser()];
+ WebDialogWindowController* web_dialog_window_controller =
+ [[WebDialogWindowController alloc] initWithDelegate:&delegate_
+ profile:profile()
+ browser:browser()];
- [html_dialog_window_controller loadDialogContents];
- [html_dialog_window_controller showWindow:nil];
- [html_dialog_window_controller close];
+ [web_dialog_window_controller loadDialogContents];
+ [web_dialog_window_controller showWindow:nil];
+ [web_dialog_window_controller close];
}
} // namespace
« no previous file with comments | « chrome/browser/ui/cocoa/web_dialog_window_controller.mm ('k') | chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698