Issue 10213011: Attempt 3 at a better touch tabstrip. There is still a bunch to do,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10213011: Attempt 3 at a better touch tabstrip. There is still a bunch to do, (Closed)

Created:
8 years, 8 months ago by sky

Modified:
8 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Attempt 3 at a better touch tabstrip. There is still a bunch to do, but this gets things in a better state. BUG=123274 TEST=covered by unit tests. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133930

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Fix check_index #

Patch Set 4 : Fix painting #

Patch Set 5 : Remove Tab::GetTouchModeMinimumSize #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1264 lines, -367 lines)			Patch
M	chrome/browser/ui/views/tabs/base_tab.cc	View		1 chunk	+15 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/browser_tab_strip_controller.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc	View		4 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/default_tab_drag_controller.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.h	View	1 2 3 4	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.cc	View	1 2 3 4	4 chunks	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_controller.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.h	View	1	11 chunks	+28 lines, -46 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.cc	View	1 2 3 4	26 chunks	+201 lines, -281 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip_controller.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/ui/views/tabs/touch_tab_strip_layout.h	View		1 chunk	+214 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/tabs/touch_tab_strip_layout.cc	View		1 chunk	+386 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/tabs/touch_tab_strip_layout_unittest.cc	View	1	1 chunk	+374 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/view_model.h	View	1 2	3 chunks	+13 lines, -0 lines	0 comments	Download
M	ui/views/view_model.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages