Attempt 3 at a better touch tabstrip. There is still a bunch to do,

chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/browser_tab_strip_controller.h"
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "chrome/browser/extensions/extension_tab_helper.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
@@ skipping 181 matching lines @@
 }
 
 bool BrowserTabStripController::IsValidIndex(int index) const {
   return model_->ContainsIndex(index);
 }
 
 bool BrowserTabStripController::IsActiveTab(int model_index) const {
   return model_->active_index() == model_index;
 }
 
+int BrowserTabStripController::GetActiveIndex() const {
+  return model_->active_index();
+}
+
 bool BrowserTabStripController::IsTabSelected(int model_index) const {
   return model_->IsTabSelected(model_index);
 }
 
 bool BrowserTabStripController::IsTabPinned(int model_index) const {
   return model_->ContainsIndex(model_index) && model_->IsTabPinned(model_index);
 }
 
 bool BrowserTabStripController::IsTabCloseable(int model_index) const {
   return !model_->ContainsIndex(model_index) ||
@@ skipping 104 matching lines @@
 
 bool BrowserTabStripController::IsIncognito() {
   return browser_->profile()->IsOffTheRecord();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserTabStripController, TabStripModelObserver implementation:
 
 void BrowserTabStripController::TabInsertedAt(TabContentsWrapper* contents,
                                               int model_index,
-                                              bool active) {
+                                              bool is_active) {
   DCHECK(contents);
   DCHECK(model_index == TabStripModel::kNoTab ||
          model_->ContainsIndex(model_index));
 
   // Cancel any pending tab transition.
   hover_tab_selector_.CancelTabTransition();
 
   TabRendererData data;
   SetTabRendererDataFromModel(contents->web_contents(), model_index, &data,
                               NEW_TAB);
-  tabstrip_->AddTabAt(model_index, data);
+  tabstrip_->AddTabAt(model_index, data, is_active);
 }
 
 void BrowserTabStripController::TabDetachedAt(TabContentsWrapper* contents,
                                               int model_index) {
   // Cancel any pending tab transition.
   hover_tab_selector_.CancelTabTransition();
 
   tabstrip_->RemoveTabAt(model_index);
 }
 
 void BrowserTabStripController::TabSelectionChanged(
     TabStripModel* tab_strip_model,
     const TabStripSelectionModel& old_model) {
   tabstrip_->SetSelection(old_model, model_->selection_model());
 }
 
 void BrowserTabStripController::TabMoved(TabContentsWrapper* contents,
                                          int from_model_index,
                                          int to_model_index) {
   // Cancel any pending tab transition.
   hover_tab_selector_.CancelTabTransition();
 
-  // Update the data first as the pinned state may have changed.
+  // Pass in the TabRendererData as the pinned state may have changed.
   TabRendererData data;
   SetTabRendererDataFromModel(contents->web_contents(), to_model_index, &data,
                               EXISTING_TAB);
-  tabstrip_->SetTabData(from_model_index, data);
-
-  tabstrip_->MoveTab(from_model_index, to_model_index);
+  tabstrip_->MoveTab(from_model_index, to_model_index, data);
 }
 
 void BrowserTabStripController::TabChangedAt(TabContentsWrapper* contents,
                                              int model_index,
                                              TabChangeType change_type) {
   if (change_type == TITLE_NOT_LOADING) {
     tabstrip_->TabTitleChangedNotLoading(model_index);
     // We'll receive another notification of the change asynchronously.
     return;
   }
@@ skipping 100 matching lines @@
 
 void BrowserTabStripController::StopHighlightTabsForCommand(
     TabStripModel::ContextMenuCommand command_id,
     BaseTab* tab) {
   if (command_id == TabStripModel::CommandCloseTabsToRight ||
       command_id == TabStripModel::CommandCloseOtherTabs) {
     // Just tell all Tabs to stop pulsing - it's safe.
     tabstrip_->StopAllHighlighting();
   }
 }