Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 10212005: Revert 133666 - Do not auto-select the first file on entering a folder. (Closed)

Created:
8 years, 8 months ago by flackr
Modified:
8 years, 8 months ago
Reviewers:
Oleg Eterevsky
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Revert 133666 - Do not auto-select the first file on entering a folder. This broke the SelectFileDialogExtensionBrowserTest.SelectFileAndOpen test on linux chromiumos browser_tests. BUG=chromium-os:26471 TEST=After entering the folder none of the files is selected. Review URL: https://chromiumcodereview.appspot.com/10204015 TBR=oleg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
MM chrome/browser/resources/file_manager/js/directory_model.js View 9 chunks +30 lines, -9 lines 0 comments Download
MM chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
flackr
8 years, 8 months ago (2012-04-24 19:21:25 UTC) #1
Oleg Eterevsky
8 years, 8 months ago (2012-04-25 09:46:17 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698