Issue 10204015: Do not auto-select the first file on entering a folder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10204015: Do not auto-select the first file on entering a folder. (Closed)

Created:
8 years, 8 months ago by Oleg Eterevsky

Modified:
8 years, 8 months ago

Reviewers:
Vladislav Kaznacheev, dgozman, SeRya

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Do not auto-select the first file on entering a folder. BUG=chromium-os:26471 TEST=After entering the folder none of the files is selected. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133666

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -33 lines)			Patch
	M	chrome/browser/resources/file_manager/js/directory_model.js	View		9 chunks	+9 lines, -30 lines	2 comments	Download
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dgozman

LGTM with nit Cleanup, more cleanup! I like it. https://chromiumcodereview.appspot.com/10204015/diff/1/chrome/browser/resources/file_manager/js/directory_model.js File chrome/browser/resources/file_manager/js/directory_model.js (right): https://chromiumcodereview.appspot.com/10204015/diff/1/chrome/browser/resources/file_manager/js/directory_model.js#newcode685 chrome/browser/resources/file_manager/js/directory_model.js:685: ...

8 years, 8 months ago (2012-04-24 11:28:28 UTC) #2

Oleg Eterevsky

8 years, 8 months ago (2012-04-24 11:29:50 UTC) #3

Thank you for the review.

https://chromiumcodereview.appspot.com/10204015/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/directory_model.js (right):

https://chromiumcodereview.appspot.com/10204015/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/directory_model.js:685: * @param
{DirectoryEntry} dirEntry The absolute path to the new directory.
On 2012/04/24 11:28:28, dgozman wrote:
> It's not a path, but an entry.

Done.

Expand Messages | Collapse Messages