Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 10210012: GDataDB support with leveldb. (Closed)

Created:
8 years, 8 months ago by achuithb
Modified:
8 years, 8 months ago
Reviewers:
xiyuan, satorux1, zel
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

GDataDB support with leveldb. * Define GDataDB interface with methods to Put, Get and Delete. Also define a path-based iterator. * GDataLevelDB implements GDataDB using leveldb. * Add methods SerializeToString and FromProtoString to serialize GDataEntry to strings and vice versa. * GDataDBTests test Put, Get, Delete for files and directories. * Iterator tests in GDataDBTests. * GDataDBFactory class to create GDataLevelDB instance. * Update deps to allow leveldatabase. TODO: * There is no integration with GDataRootDirectory/GDataFileSystem yet. BUG=chromium-os:29232 TEST=unittests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133833

Patch Set 1 #

Patch Set 2 : update DEPS #

Patch Set 3 : shorten prefixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+739 lines, -14 lines) Patch
A chrome/browser/chromeos/gdata/DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/gdata/gdata_db.h View 1 chunk +69 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/gdata/gdata_db_factory.h View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/gdata/gdata_db_factory.cc View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/gdata/gdata_db_unittest.cc View 1 chunk +266 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_files.h View 5 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_files.cc View 7 chunks +64 lines, -6 lines 0 comments Download
A chrome/browser/chromeos/gdata/gdata_leveldb.h View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/gdata/gdata_leveldb.cc View 1 2 1 chunk +204 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
achuithb
Previous CL here: http://codereview.chromium.org/10168025/ Reverted due to deps failure here: http://build.chromium.org/p/chromium/builders/Linux%20Builder%20x64/builds/42640/steps/check_deps/logs/stdio
8 years, 8 months ago (2012-04-25 00:33:57 UTC) #1
achuithb
Identical to http://codereview.chromium.org/10168025/ except for addition of DEPS.
8 years, 8 months ago (2012-04-25 01:13:06 UTC) #2
achuithb
Zel requests shorter prefix.
8 years, 8 months ago (2012-04-25 01:18:50 UTC) #3
zel
lgtm
8 years, 8 months ago (2012-04-25 01:21:34 UTC) #4
achuithb
On 2012/04/25 01:21:34, zel wrote: > lgtm Thanks Zel!
8 years, 8 months ago (2012-04-25 01:22:06 UTC) #5
xiyuan
check_deps fail seems to be real and you might want to fix that. ERROR in ...
8 years, 8 months ago (2012-04-25 01:40:25 UTC) #6
achuithb
On 2012/04/25 01:40:25, xiyuan wrote: > check_deps fail seems to be real and you might ...
8 years, 8 months ago (2012-04-25 01:50:02 UTC) #7
xiyuan
8 years, 8 months ago (2012-04-25 01:56:07 UTC) #8
On 2012/04/25 01:50:02, achuith.bhandarkar wrote:
> On 2012/04/25 01:40:25, xiyuan wrote:
> > check_deps fail seems to be real and you might want to fix that.
> > 
> > ERROR in
> >
>
/mnt/data/b/build/slave/linux/build/src/chrome/browser/chromeos/gdata/gdata_leveldb.cc
> > Illegal include: "leveldb/write_batch.h"
> >     Because of no rule applying
> 
> I believe this CL fixes the DEPS failure? There was an earlier CL that didn't
> have this fix. Are you at TOT?

You are right. I was on r133818.

Powered by Google App Engine
This is Rietveld 408576698