ash: Add vertical spacing to multi-line text in tray.

ash: Add vertical spacing to multi-line text in tray.

This breaks the multi-line date/day-of-week and battery text
in the uber system tray across multiple labels so we can add
a bit more spacing between the lines.

A side effect (maybe a slight improvement?) is that some of
the longer strings (e.g.  "Calculating remaining time") now
get elided instead of getting wrapped and clipped.

Since I needed to change the battery-related strings anyway,
I'm also splitting the "2h 23m"-style string into
"2h 23m remaining" and "2h 23m until full".

BUG=124664, 124074
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134585

[Daniel Erat, 2012-04-27 23:22:06]

https://chromiumcodereview.appspot.com/10209038/diff/1/ash/system/date/date_v...
File ash/system/date/date_view.h (right):

https://chromiumcodereview.appspot.com/10209038/diff/1/ash/system/date/date_v...
ash/system/date/date_view.h:24: class BaseDateTimeView : public ActionableView {
Let me know if you think that this is ugly and would prefer composition (e.g.
some kind of updater class) to inheritance here.

[sadrul, 2012-04-30 15:05:52]

http://codereview.chromium.org/10209038/diff/1/ash/system/date/date_view.cc
File ash/system/date/date_view.cc (right):

http://codereview.chromium.org/10209038/diff/1/ash/system/date/date_view.cc#n...
ash/system/date/date_view.cc:121: 
-newline. Perhaps move implementation of BaseDateTimeView above DateView

http://codereview.chromium.org/10209038/diff/1/ash/system/date/date_view.cc#n...
ash/system/date/date_view.cc:131:
GetWidget()->GetContentsView()->GetPreferredSize() != old_size) {
I believe this should just be 'GetPreferredSize() != old_size'? (because
|old_size| is for |this|)

http://codereview.chromium.org/10209038/diff/1/ash/system/date/date_view.h
File ash/system/date/date_view.h (right):

http://codereview.chromium.org/10209038/diff/1/ash/system/date/date_view.h#ne...
ash/system/date/date_view.h:24: class BaseDateTimeView : public ActionableView {
On 2012/04/27 23:22:06, Daniel Erat wrote:
> Let me know if you think that this is ugly and would prefer composition (e.g.
> some kind of updater class) to inheritance here.

This looks good.

[Daniel Erat, 2012-04-30 17:12:43]

http://codereview.chromium.org/10209038/diff/1/ash/system/date/date_view.cc
File ash/system/date/date_view.cc (right):

http://codereview.chromium.org/10209038/diff/1/ash/system/date/date_view.cc#n...
ash/system/date/date_view.cc:121: 
On 2012/04/30 15:05:52, sadrul wrote:
> -newline. Perhaps move implementation of BaseDateTimeView above DateView

Done.

http://codereview.chromium.org/10209038/diff/1/ash/system/date/date_view.cc#n...
ash/system/date/date_view.cc:131:
GetWidget()->GetContentsView()->GetPreferredSize() != old_size) {
On 2012/04/30 15:05:52, sadrul wrote:
> I believe this should just be 'GetPreferredSize() != old_size'? (because
> |old_size| is for |this|)

Done.  It looks like I still need to call SetSize() on the widget rather than on
the view, though.

[sadrul, 2012-04-30 17:21:42]

lgtm

[commit-bot: I haz the power, 2012-04-30 20:01:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10209038/4002

[commit-bot: I haz the power, 2012-04-30 20:14:19]

Try job failure for 10209038-4002 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.