Issue 10206021: Merge 133595 - ash: Fix transparency glitches in window header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10206021: Merge 133595 - ash: Fix transparency glitches in window header (Closed)

Created:
8 years, 8 months ago by James Cook

Modified:
8 years, 8 months ago

Reviewers:
James Cook

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1084/src/

Visibility:
Public.

More Reviews

Description

Merge 133595 - ash: Fix transparency glitches in window header Due to a race between when window show/hide animations change IsVisible() and "solo" window counting for determining header transparency, a missed update when windows are hidden, and FramePainter::PaintHeader() being called repeatedly with different clip rects for widget updates, we could get into a state where the window header has different transparency values behind various views::View widgets. Fix this by using Window::TargetVisibility() instead of IsVisible() and monitoring for window visibility change events. BUG=123866 TEST=manual, see bug Review URL: http://codereview.chromium.org/10192001 TBR=jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133685

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -12 lines)			Patch
	M	ash/wm/frame_painter.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
	M	ash/wm/frame_painter.cc	View		4 chunks	+25 lines, -12 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages