Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1896)

Issue 10204020: Revert 114994 - Merge 114699 - REGRESSION(r112177): Numbered list item rendered bulleted (Closed)

Created:
8 years, 8 months ago by aarya
Modified:
8 years, 8 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Revert 114994 - Merge 114699 - REGRESSION(r112177): Numbered list item rendered bulleted https://bugs.webkit.org/show_bug.cgi?id=84216 Patch by David Barr <davidbarr@chromium.org>; on 2012-04-19 Reviewed by Ryosuke Niwa. Shorthands that imply omitted values cannot be derived from an incomplete set of longhand rules. No new tests; updated existing tests that should have caught this. Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseTransformOriginShorthand): Set implicit initial for Z when omitted. * css/StylePropertySet.cpp: (WebCore::StylePropertySet::getShorthandValue): LayoutTests: * css3/flexbox/css-properties.html: * fast/css/cssText-shorthand.html: * fast/css/uri-token-parsing-expected.txt: * fast/css/uri-token-parsing.html: * fast/dom/css-dom-read-2-expected.txt: TBR=commit-queue@webkit.org Review URL: https://chromiumcodereview.appspot.com/10140014 TBR=mikelawther@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=115069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M LayoutTests/fast/css/cssText-shorthand.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/uri-token-parsing.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/uri-token-parsing-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/css-dom-read-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/css/CSSParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/css/StylePropertySet.cpp View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
aarya
8 years, 8 months ago (2012-04-24 16:18:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698