Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 10140014: Merge 114699 - REGRESSION(r112177): Numbered list item rendered bulleted (Closed)

Created:
8 years, 8 months ago by Mike Lawther (Google)
Modified:
8 years, 8 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 114699 - REGRESSION(r112177): Numbered list item rendered bulleted https://bugs.webkit.org/show_bug.cgi?id=84216 Patch by David Barr <davidbarr@chromium.org>; on 2012-04-19 Reviewed by Ryosuke Niwa. Shorthands that imply omitted values cannot be derived from an incomplete set of longhand rules. No new tests; updated existing tests that should have caught this. Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseTransformOriginShorthand): Set implicit initial for Z when omitted. * css/StylePropertySet.cpp: (WebCore::StylePropertySet::getShorthandValue): LayoutTests: * css3/flexbox/css-properties.html: * fast/css/cssText-shorthand.html: * fast/css/uri-token-parsing-expected.txt: * fast/css/uri-token-parsing.html: * fast/dom/css-dom-read-2-expected.txt: TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=114994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M LayoutTests/fast/css/cssText-shorthand.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/uri-token-parsing.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/uri-token-parsing-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/css-dom-read-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/css/CSSParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/css/StylePropertySet.cpp View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mike Lawther (Google)
8 years, 8 months ago (2012-04-24 04:26:56 UTC) #1
Hironori Bono
8 years, 8 months ago (2012-04-24 08:14:05 UTC) #2
Greetings Mike,

Unfortunately, this change causes a build break on our official builders as
listed below. (It seems this change depends on r113647
<http://trac.webkit.org/changeset/113647>.) Would it be possible to merge
r113647 or replace 'cssValuePool().createImplicitInitialValue()' with
'cssValuePool()->createImplicitInitialValue();'?

* Win
 
http://chrome-master2.mtv.corp.google.com:8011/builders/win%20beta/builds/697...
* Mac
 
http://chrome-master2.mtv.corp.google.com:8011/builders/mac%20beta/builds/911...
* Linux x32
 
http://chrome-master2.mtv.corp.google.com:8011/builders/linux32%20beta/builds...

Regards,

Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698