Reenable test.dart to be invoked from dartium checkout

tools/testing/dart/test_suite.dart

Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index ea5fdf0dddc785f33f619f92ee43b0c2b13942e4..a33b17c2c5dcab1e51f41c76470ac76639d57ee5 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -666,6 +666,11 @@ class StandardTestSuite implements TestSuite {
       default:
         Expect.fail('unimplemented compiler $compiler');
     }
+    if (executable.endsWith('.dart')) {
+      // Run the compiler script via the Dart VM.
+      args.insertRange(0, 1, executable);
+      executable = TestUtils.dartShellFileName(configuration);
+    }
     return new Command(executable, args);
   }
 
@@ -1257,7 +1262,10 @@ class TestUtils {
   }
 
   static String dartShellFileName(Map configuration) {
-    var name = '${buildDir(configuration)}/${executableName(configuration)}';
+    var name = configuration['shell'];
+    if (name == '') {
+      name = '${buildDir(configuration)}/${executableName(configuration)}';

[Bill Hesse, 2012/04/24 09:28:25]

The real problem is that the buildDir is not correct - it is out/Release_ia32
rather than out/Release.  I would prefer much more that you either make the
buildDir(configuration) helper function find the right directory automatically,
by checking which one exists, or else that you introduce a --build-dir flag,
which overrides the calculated build directory.  That would fix both the dart
executable and the drt paths, I think.  I am ok with the --dart flag (instead of
--shell), but it won't be needed if you have --build-dir instead, or if build
dir is computed automatically.

[vsm, 2012/04/24 16:05:57]

It's a little more complicated than that.  In an all.deps enlistment, DRT is
downloaded on demand to:
./client/tests/drt
In a Dartium enlistment, that actually works fine, but you of course want to use
the DRT you built under out/Release.

For the compiler (frog), in an all.deps enlistment, a compiler "executable" is
placed under out/Release_ia32/frog/bin/frog - which is what the tests use.  In a
Dartium enlistment, we don't build frog (we'd have to change chrome trunk's gyp
to do it), so this change invokes the compiler via the vm.

The VM is the one thing out of the three that is actually built in both
enlistments.

On 2012/04/24 09:28:25, Bill Hesse wrote:

+    }
     if (!(new File(name)).existsSync() && !configuration['list']) {
       throw "Executable '$name' does not exist";
     }