Reenable test.dart to be invoked from dartium checkout

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 648 matching lines @@
         }
         args.addAll(['--libdir=$libdir',
                              '--compile-only',
                              '--out=$outputFile']);
         args.addAll(vmOptions);
         args.add(inputFile);
         break;
       default:
         Expect.fail('unimplemented compiler $compiler');
     }
+    if (executable.endsWith('.dart')) {
+      // Run the compiler script via the Dart VM.
+      args.insertRange(0, 1, executable);
+      executable = TestUtils.dartShellFileName(configuration);
+    }
     return new Command(executable, args);
   }
 
   bool get requiresCleanTemporaryDirectory() =>
       configuration['compiler'] == 'dartc';
 
   /**
    * Create a directory for the generated test.  If a Dart language test
    * needs to be run in a browser, the Dart test needs to be embedded in
    * an HTML page, with a testing framework based on scripting and DOM events.
@@ skipping 571 matching lines @@
         return 'compiler/bin/dartc$suffix';
       case 'frog':
       case 'dart2js':
         return 'frog/bin/frog$suffix';
       default:
         throw "Unknown compiler for: ${configuration['compiler']}";
     }
   }
 
   static String dartShellFileName(Map configuration) {
-    var name = '${buildDir(configuration)}/${executableName(configuration)}';
+    var name = configuration['shell'];
+    if (name == '') {
+      name = '${buildDir(configuration)}/${executableName(configuration)}';

[Bill Hesse, 2012/04/24 09:28:25]

The real problem is that the buildDir is not correct - it is out/Release_ia32
rather than out/Release.  I would prefer much more that you either make the
buildDir(configuration) helper function find the right directory automatically,
by checking which one exists, or else that you introduce a --build-dir flag,
which overrides the calculated build directory.  That would fix both the dart
executable and the drt paths, I think.  I am ok with the --dart flag (instead of
--shell), but it won't be needed if you have --build-dir instead, or if build
dir is computed automatically.

[vsm, 2012/04/24 16:05:57]

It's a little more complicated than that.  In an all.deps enlistment, DRT is
downloaded on demand to:
./client/tests/drt
In a Dartium enlistment, that actually works fine, but you of course want to use
the DRT you built under out/Release.

For the compiler (frog), in an all.deps enlistment, a compiler "executable" is
placed under out/Release_ia32/frog/bin/frog - which is what the tests use.  In a
Dartium enlistment, we don't build frog (we'd have to change chrome trunk's gyp
to do it), so this change invokes the compiler via the vm.

The VM is the one thing out of the three that is actually built in both
enlistments.

On 2012/04/24 09:28:25, Bill Hesse wrote:

+    }
     if (!(new File(name)).existsSync() && !configuration['list']) {
       throw "Executable '$name' does not exist";
     }
     return name;
   }
 
   static String compilerPath(Map configuration) {
     if (configuration['compiler'] == 'none') {
       return null;  // No separate compiler for dartium tests.
     }
@@ skipping 104 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }