Refactoring of heap profiler: split ExtractReferences into several functions.

Refactoring of heap profiler: split ExtractReferences into several functions.

Committed: https://code.google.com/p/v8/source/detail?r=11424

[mnaganov (inactive), 2012-04-24 12:25:45]

https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator....
src/profile-generator.cc:1975: void
V8HeapExplorer::ExtractJSGlobalProxy(JSGlobalProxy* proxy) {
I think you should put these functions after ExtractReferences, so first you see
the top-level function, and then its helpers.

https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator....
src/profile-generator.h:988: 
nit: Why blank line?

[alexeif, 2012-04-24 12:33:28]

https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator....
src/profile-generator.cc:1975: void
V8HeapExplorer::ExtractJSGlobalProxy(JSGlobalProxy* proxy) {
On 2012/04/24 12:25:45, Mikhail Naganov (Chromium) wrote:
> I think you should put these functions after ExtractReferences, so first you
see
> the top-level function, and then its helpers.

Done.

https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator.h
File src/profile-generator.h (right):

https://chromiumcodereview.appspot.com/10198011/diff/1/src/profile-generator....
src/profile-generator.h:988: 
On 2012/04/24 12:25:45, Mikhail Naganov (Chromium) wrote:
> nit: Why blank line?

Done.

[mnaganov (inactive), 2012-04-24 12:35:44]

lgtm

[yurys, 2012-04-25 06:30:44]

https://chromiumcodereview.appspot.com/10198011/diff/5001/src/profile-generat...
File src/profile-generator.h (right):

https://chromiumcodereview.appspot.com/10198011/diff/5001/src/profile-generat...
src/profile-generator.h:988: void ExtractCode(HeapEntry* entry, Code* code);
You should be more consistent in using/not using *References suffix: currently
it is ExtractCode but ExtractClosureReferences.