Refactoring of heap profiler: split ExtractReferences into several functions.

src/profile-generator.h

Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index 3b748e234f1823644325c6c2ef6ec069341ada66..1468777fc77d7684e1b0b4c4d65dbe898e53b980 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -975,7 +975,17 @@ class V8HeapExplorer : public HeapEntriesAllocator {
                       int children_count,
                       int retainers_count);
   const char* GetSystemEntryName(HeapObject* object);
+
   void ExtractReferences(HeapObject* obj);
+  void ExtractJSGlobalProxy(JSGlobalProxy* proxy);
+  void ExtractJSObject(HeapEntry* entry, JSObject* js_obj);
+  void ExtractString(HeapEntry* entry, String* obj);
+  void ExtractContext(HeapEntry* entry, Context* context);
+  void ExtractMap(HeapEntry* entry, Map* map);
+  void ExtractSharedFunctionInfo(HeapEntry* entry, SharedFunctionInfo* shared);
+  void ExtractScript(HeapEntry* entry, Script* script);
+  void ExtractCodeCache(HeapEntry* entry, CodeCache* code_cache);
+  void ExtractCode(HeapEntry* entry, Code* code);

[yurys, 2012/04/25 06:30:44]

You should be more consistent in using/not using *References suffix: currently
it is ExtractCode but ExtractClosureReferences.

   void ExtractClosureReferences(JSObject* js_obj, HeapEntry* entry);
   void ExtractPropertyReferences(JSObject* js_obj, HeapEntry* entry);
   void ExtractElementReferences(JSObject* js_obj, HeapEntry* entry);