Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: tests/standalone/src/io/ProcessTestUtil.dart

Issue 10190005: Fix timeouts in standalone/io/TestRunnerTest by increasing timeout. Fix a few errors in test_runne… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix builds with only x64 architecture. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/standalone/src/io/TestRunnerTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/io/ProcessTestUtil.dart
diff --git a/tests/standalone/src/io/ProcessTestUtil.dart b/tests/standalone/src/io/ProcessTestUtil.dart
index 0f80c3643849dade5b1dbfee7803fd89f4936030..258d89ce6e4c4e1749ede94716fbe824a6d66b82 100644
--- a/tests/standalone/src/io/ProcessTestUtil.dart
+++ b/tests/standalone/src/io/ProcessTestUtil.dart
@@ -18,8 +18,12 @@ String getPlatformExecutableExtension() {
String getProcessTestFileName() {
var outDir = getPlatformOutDir();
var extension = getPlatformExecutableExtension();
+ // We do not expose information about the mode or architecture we are testing
+ // to the tests themselves, so we use any working copy.
var names = ['${outDir}Release_ia32/process_test$extension',
- '${outDir}Debug_ia32/process_test$extension'];
+ '${outDir}Debug_ia32/process_test$extension',
+ '${outDir}Release_x64/process_test$extension',
+ '${outDir}Debug_x64/process_test$extension'];
for (var name in names) {
if (new File(name).existsSync()) {
@@ -32,8 +36,12 @@ String getProcessTestFileName() {
String getDartFileName() {
var outDir = getPlatformOutDir();
var extension = getPlatformExecutableExtension();
+ // We do not expose information about the mode or architecture we are testing
+ // to the tests themselves, so we use any working dart shell.
var names = ['${outDir}Release_ia32/dart$extension',
- '${outDir}Debug_ia32/dart$extension'];
+ '${outDir}Debug_ia32/dart$extension',
+ '${outDir}Release_x64/dart$extension',
+ '${outDir}Debug_x64/dart$extension'];
for (var name in names) {
if (new File(name).existsSync()) {
« no previous file with comments | « no previous file | tests/standalone/src/io/TestRunnerTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698