Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: tests/standalone/src/io/TestRunnerTest.dart

Issue 10190005: Fix timeouts in standalone/io/TestRunnerTest by increasing timeout. Fix a few errors in test_runne… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix builds with only x64 architecture. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/src/io/ProcessTestUtil.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/io/TestRunnerTest.dart
diff --git a/tests/standalone/src/io/TestRunnerTest.dart b/tests/standalone/src/io/TestRunnerTest.dart
index 4163d4923df413962c54c8c132bad06b704f3cb9..a6812bde8b54b44efa27873de60d52b4295f88cb 100644
--- a/tests/standalone/src/io/TestRunnerTest.dart
+++ b/tests/standalone/src/io/TestRunnerTest.dart
@@ -60,7 +60,11 @@ void main() {
new RunningProcess(MakeTestCase("FailTest", [FAIL])).start();
new RunningProcess(MakeTestCase("TimeoutTest", [TIMEOUT])).start();
- var configuration = new TestOptionsParser().parse(['--timeout', '10'])[0];
+ // The crash test sometimes times out. Run it with a large timeout to help
+ // diagnose the delay.
+ // The test loads a new executable, which may sometimes take a long time.
+ // It involves a wait on the VM event loop, and possible system delays.
+ var configuration = new TestOptionsParser().parse(['--timeout', '60'])[0];
new RunningProcess(new TestCase("CrashTest",
[new Command(getProcessTestFileName(),
const ["0", "0", "1", "1"])],
« no previous file with comments | « tests/standalone/src/io/ProcessTestUtil.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698