Issue 10186001: Revert 133427 - Attempt to load component extension favicon from the resources first.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10186001: Revert 133427 - Attempt to load component extension favicon from the resources first. (Closed)

Created:
8 years, 8 months ago by dgozman

Modified:
8 years, 8 months ago

Reviewers:
dgozman

CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 133427 - Attempt to load component extension favicon from the resources first. This broke BackgroundApplicationListModelTest.ExplicitTest. Special handling of CWS icon. Also correctly handle URL rewrites in favicon requests. BUG=chromium-os:28314, chromium:120471 TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon. Review URL: https://chromiumcodereview.appspot.com/9979001 TBR=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133428

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -167 lines)			Patch
M	chrome/browser/extensions/extension_icon_manager_unittest.cc	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	chrome/browser/extensions/image_loading_tracker.h	View	3 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/image_loading_tracker.cc	View	4 chunks	+5 lines, -66 lines	0 comments	Download
M	chrome/browser/extensions/image_loading_tracker_unittest.cc	View	8 chunks	+6 lines, -32 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_icon_source.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_icon_source.cc	View	2 chunks	+24 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/file_manager/app.json	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	chrome/test/data/extensions/file_manager/images/icon16.png	View	Binary file		0 comments	Download

Total messages: 1 (0 generated)