Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
9979001:
Attempt to load component extension favicon from the resources first. (Closed)
|
Created:
8 years, 8 months ago by dgozman Modified:
8 years, 8 months ago CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src/ Visibility:
Public. |
DescriptionAttempt to load component extension favicon from the resources first.
Special handling of CWS icon.
Also correctly handle URL rewrites in favicon requests.
BUG=chromium-os:28314, chromium:120471
TEST=Observe the right favicon for CWS and FileManager component extension. Bookmark them and see the right favicon.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133657
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #
Total comments: 2
Patch Set 5 : #
Total comments: 4
Patch Set 6 : #
Total comments: 6
Patch Set 7 : #
Total comments: 4
Patch Set 8 : Codestyle fixes. #Patch Set 9 : #
Total comments: 12
Patch Set 10 : #Patch Set 11 : Restricted one test to ChromeOS platform. #Patch Set 12 : Another guard in test. #Patch Set 13 : #Patch Set 14 : Moved CWS check earlier. #Patch Set 15 : Fixed ExplicitTest. #Patch Set 16 : Merge #Messages
Total messages: 420 (0 generated)
May you have a look please?
ExtensionIconSource does pretty much the same thing. I wonder if this should just go in ImageLoadingTracker, rather than all its clients?
Moved the code to ImageLoadingTracker. Please, take a look. James, you approval required for chrome/browser/ui/webui.
https://chromiumcodereview.appspot.com/9979001/diff/6005/chrome/browser/ui/we... File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/6005/chrome/browser/ui/we... chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:426: ExtensionWebUI::HandleChromeURLOverride(&url, profile); This needs an explanatory comment.
PTAL https://chromiumcodereview.appspot.com/9979001/diff/6005/chrome/browser/ui/we... File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/6005/chrome/browser/ui/we... chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:426: ExtensionWebUI::HandleChromeURLOverride(&url, profile); On 2012/04/06 04:45:25, James Hawkins wrote: > This needs an explanatory comment. Done.
LGTM with nit. https://chromiumcodereview.appspot.com/9979001/diff/7003/chrome/browser/exten... File chrome/browser/extensions/image_loading_tracker.h (right): https://chromiumcodereview.appspot.com/9979001/diff/7003/chrome/browser/exten... chrome/browser/extensions/image_loading_tracker.h:128: SkBitmap *TryLoadingComponentExtensionImage( s/SkBitmap */SkBitmap* /
https://chromiumcodereview.appspot.com/9979001/diff/7003/chrome/browser/exten... File chrome/browser/extensions/image_loading_tracker.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/7003/chrome/browser/exten... chrome/browser/extensions/image_loading_tracker.cc:189: // If we don't have a path we don't need to do any further work, just It looks like I'm fixing the same issue (http://code.google.com/p/chromium/issues/detail?id=120471). Your changes fix icon for FileManager but they won't fix WebStore icon because icons section is missing in CWS manifest. To make CWS icon work too you also need to move check for CWS app ID (see my CL http://codereview.chromium.org/9949012). I can merge my CL with your after your commit or you can extract part of my CL to yours. Basically you need to insert here: if (load_info.extension_id == extension_misc::kWebStoreAppId) { OnImageLoaded( ExtensionIconSource::LoadImageByResourceId(IDR_WEBSTORE_ICON), it->resource, it->max_size, id, false); continue; } And remove check from ExtensionIconSource.
Dmitry, Mihai, may you have a look please? https://chromiumcodereview.appspot.com/9979001/diff/7003/chrome/browser/exten... File chrome/browser/extensions/image_loading_tracker.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/7003/chrome/browser/exten... chrome/browser/extensions/image_loading_tracker.cc:189: // If we don't have a path we don't need to do any further work, just On 2012/04/09 11:15:56, Dmitry Polukhin wrote: > It looks like I'm fixing the same issue > (http://code.google.com/p/chromium/issues/detail?id=120471). Your changes fix > icon for FileManager but they won't fix WebStore icon because icons section is > missing in CWS manifest. To make CWS icon work too you also need to move check > for CWS app ID (see my CL http://codereview.chromium.org/9949012). I can merge > my CL with your after your commit or you can extract part of my CL to yours. > > Basically you need to insert here: > if (load_info.extension_id == extension_misc::kWebStoreAppId) { > OnImageLoaded( > ExtensionIconSource::LoadImageByResourceId(IDR_WEBSTORE_ICON), > it->resource, it->max_size, id, false); > continue; > } > And remove check from ExtensionIconSource. Done. https://chromiumcodereview.appspot.com/9979001/diff/7003/chrome/browser/exten... File chrome/browser/extensions/image_loading_tracker.h (right): https://chromiumcodereview.appspot.com/9979001/diff/7003/chrome/browser/exten... chrome/browser/extensions/image_loading_tracker.h:128: SkBitmap *TryLoadingComponentExtensionImage( On 2012/04/06 19:23:57, James Hawkins wrote: > s/SkBitmap */SkBitmap* / Done.
LGTM
Mihai, Finnur, Jon, May you look at chrome/browser/extensions/* please?
https://chromiumcodereview.appspot.com/9979001/diff/12001/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/12001/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.cc:209: OnImageLoaded(from_resources, it->resource, it->max_size, id, false); You've selected in both cases to not honor the |cache| param and hard-code it to false instead. Is that what we want?
https://chromiumcodereview.appspot.com/9979001/diff/12001/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/12001/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.cc:209: OnImageLoaded(from_resources, it->resource, it->max_size, id, false); On 2012/04/10 13:46:39, Finnur wrote: > You've selected in both cases to not honor the |cache| param and hard-code it to > false instead. Is that what we want? Why do we cache icon available locally and waste some space?
https://chromiumcodereview.appspot.com/9979001/diff/12001/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/12001/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.cc:209: OnImageLoaded(from_resources, it->resource, it->max_size, id, false); All the files this class deals with are local, so I don't see how this would be different? We cache so we don't have to load the files from disk each time and can respond quickly with the image on the UI thread when it has been loaded once. The question you should be asking yourself is: The API for this class allows for caching of the image. Are you certain it is correct in all cases to ignore the |caching| parameter when we load resources of this type? Shouldn't we let the caller decide? If so, the cache needs to be consulted first (see line 216). On 2012/04/10 14:19:48, dgozman wrote: > On 2012/04/10 13:46:39, Finnur wrote: > > You've selected in both cases to not honor the |cache| param and hard-code it > to > > false instead. Is that what we want? > > Why do we cache icon available locally and waste some space? https://chromiumcodereview.appspot.com/9979001/diff/12001/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.cc:247: kComponentExtensionResources[i].value); Wait, we're on the UI thread here so we should not be performing this request here (it does IO).
Dmitry, Finnur, please take another look. https://chromiumcodereview.appspot.com/9979001/diff/12001/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/12001/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.cc:209: OnImageLoaded(from_resources, it->resource, it->max_size, id, false); On 2012/04/10 14:32:21, Finnur wrote: > All the files this class deals with are local, so I don't see how this would be > different? We cache so we don't have to load the files from disk each time and > can respond quickly with the image on the UI thread when it has been loaded > once. > > The question you should be asking yourself is: The API for this class allows for > caching of the image. Are you certain it is correct in all cases to ignore the > |caching| parameter when we load resources of this type? Shouldn't we let the > caller decide? > > If so, the cache needs to be consulted first (see line 216). > > > On 2012/04/10 14:19:48, dgozman wrote: > > On 2012/04/10 13:46:39, Finnur wrote: > > > You've selected in both cases to not honor the |cache| param and hard-code > it > > to > > > false instead. Is that what we want? > > > > Why do we cache icon available locally and waste some space? > Oh, now I see. Changed so the |CacheParam| decides. https://chromiumcodereview.appspot.com/9979001/diff/12001/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.cc:247: kComponentExtensionResources[i].value); On 2012/04/10 14:32:21, Finnur wrote: > Wait, we're on the UI thread here so we should not be performing this request > here (it does IO). Done.
Much better. Couple of nits and wondering if you can add a test for the new functionality (maybe update image_loading_tracker_unittest.cc)? https://chromiumcodereview.appspot.com/9979001/diff/20001/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/20001/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.cc:245: } nit: No braces (single line if&else clauses). https://chromiumcodereview.appspot.com/9979001/diff/20001/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker.h (right): https://chromiumcodereview.appspot.com/9979001/diff/20001/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.h:131: int& resource_id); nit: Indentation.
Nits fixed. https://chromiumcodereview.appspot.com/9979001/diff/20001/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/20001/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.cc:245: } On 2012/04/11 10:03:09, Finnur wrote: > nit: No braces (single line if&else clauses). Done. https://chromiumcodereview.appspot.com/9979001/diff/20001/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker.h (right): https://chromiumcodereview.appspot.com/9979001/diff/20001/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.h:131: int& resource_id); On 2012/04/11 10:03:09, Finnur wrote: > nit: Indentation. Done.
Tests added. Please take a look. https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... File chrome/browser/extensions/extension_icon_manager_unittest.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/extension_icon_manager_unittest.cc:142: TEST_F(ExtensionIconManagerTest, LoadComponentExtensionResource) { Note: this is similar to the test above, but for component extension.
LGTM, with nits. https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... File chrome/browser/extensions/extension_icon_manager_unittest.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/extension_icon_manager_unittest.cc:148: "extensions/file_manager/app.json"); nit: it might make sense, for future-proofing, to have this in a separate directory below file_manager, in case someone adds more tests and needs separation, then you won't have one folder with their test and this file alone in the root. https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/extension_icon_manager_unittest.cc:153: ASSERT_TRUE(manifest.get() != NULL); nit: ASSERT_NE() ? https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/extension_icon_manager_unittest.cc:160: TestIconManager icon_manager(this); nit: This feels like more a part of the next paragraph. https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker.h (right): https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.h:153: friend class ImageLoadingTrackerTest; FRIEND_TEST_ALL_PREFIXES instead? https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker_unittest.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker_unittest.cc:57: Extension::Location location) { nit: Indentation.
Thanks for review. https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... File chrome/browser/extensions/extension_icon_manager_unittest.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/extension_icon_manager_unittest.cc:148: "extensions/file_manager/app.json"); On 2012/04/11 17:38:13, Finnur wrote: > nit: it might make sense, for future-proofing, to have this in a separate > directory below file_manager, in case someone adds more tests and needs > separation, then you won't have one folder with their test and this file alone > in the root. Not quite understood you. There are some other files inside the test extension dir. And we need the immediate parent of manifest to be named 'file_manager". https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/extension_icon_manager_unittest.cc:153: ASSERT_TRUE(manifest.get() != NULL); On 2012/04/11 17:38:13, Finnur wrote: > nit: ASSERT_NE() ? This doesn't compile for pointers. https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/extension_icon_manager_unittest.cc:160: TestIconManager icon_manager(this); On 2012/04/11 17:38:13, Finnur wrote: > nit: This feels like more a part of the next paragraph. Done. https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker.h (right): https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker.h:153: friend class ImageLoadingTrackerTest; On 2012/04/11 17:38:13, Finnur wrote: > FRIEND_TEST_ALL_PREFIXES instead? Done. https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... File chrome/browser/extensions/image_loading_tracker_unittest.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/image_loading_tracker_unittest.cc:57: Extension::Location location) { On 2012/04/11 17:38:13, Finnur wrote: > nit: Indentation. Done.
LGTM. There are some test failures on the try server (wonder why didn't it run on Windows and Mac?), but maybe the failures are because you are adding a binary file in this CL. If you are confident the failures are bogus then feel free to carry on. https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... File chrome/browser/extensions/extension_icon_manager_unittest.cc (right): https://chromiumcodereview.appspot.com/9979001/diff/27002/chrome/browser/exte... chrome/browser/extensions/extension_icon_manager_unittest.cc:148: "extensions/file_manager/app.json"); Ah, right. Never mind. :) On 2012/04/12 11:47:24, dgozman wrote: > On 2012/04/11 17:38:13, Finnur wrote: > > nit: it might make sense, for future-proofing, to have this in a separate > > directory below file_manager, in case someone adds more tests and needs > > separation, then you won't have one folder with their test and this file alone > > in the root. > > Not quite understood you. There are some other files inside the test extension > dir. And we need the immediate parent of manifest to be named 'file_manager".
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9979001/36001
On 2012/04/13 15:40:04, I haz the power (commit-bot) wrote: > CQ is trying da patch. Follow status at > https://chromium-status.appspot.com/cq/dgozman%40chromium.org/9979001/36001 As you may have realized by now, the CQ has issues with binary files.
Hi, Never seen this behavior before. I remember another problem: files were not uploaded and so tests were failing (or even not compiling). Thanks, Dmitry On Fri, Apr 13, 2012 at 7:40 PM, <maruel@chromium.org> wrote: > On 2012/04/13 15:40:04, I haz the power (commit-bot) wrote: > >> CQ is trying da patch. Follow status at >> https://chromium-status.**appspot.com/cq/dgozman%** >> 40chromium.org/9979001/36001<https://chromium-status.appspot.com/cq/dgozman%40chromium.org/9979001/36001> >> > > As you may have realized by now, the CQ has issues with binary files. > > http://codereview.chromium.**org/9979001/<http://codereview.chromium.org/9979... > |
