Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4171)

Unified Diff: chrome/browser/website_settings.h

Issue 10181004: Add comment to explain why some of the strings are typed as string16, and a TODO as a reminder to c… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/website_settings.h
diff --git a/chrome/browser/website_settings.h b/chrome/browser/website_settings.h
index 7c4f300a2a45e9aeadcd5b40a9b823a077b98c4e..fe8fb775b919d4a65a89ca17140e79c90e4a2ded 100644
--- a/chrome/browser/website_settings.h
+++ b/chrome/browser/website_settings.h
@@ -147,18 +147,25 @@ class WebsiteSettings : public TabSpecificContentSettings::SiteDataObserver {
// Status of the connection to the website.
SiteConnectionStatus site_connection_status_;
+ // TODO(markusheintz): Move the creation of all the string16 typed UI
+ // strings below to the corresponding UI code, in order to prevent
+ // unnesseccary UTF string conversions.
wtc 2012/04/23 21:49:30 Typo: unnesseccary => unnecessary Should this be
markusheintz_ 2012/04/24 08:52:59 Done.
+
// Details about the website's identity. If the website's identity has been
// verified then |site_identity_details_| contains who verified the identity.
+ // This string will be displayed in the UI.
string16 site_identity_details_;
// Details about the connection to the website. In case of an encrypted
// connection |site_connection_details_| contains encryption details, like
- // encryption strength and ssl protocol version.
+ // encryption strength and ssl protocol version. This string will be
+ // displayed in the UI.
string16 site_connection_details_;
- // For websites that provided an EV certificate |orgainization_name_| contains
- // the organization name of the certificate. In all other cases
- // |organization_name| is an empty string.
+ // For websites that provided an EV certificate |orgainization_name_|
+ // contains the organization name of the certificate. In all other cases
+ // |organization_name| is an empty string. This string will be displayed in
+ // the UI.
string16 organization_name_;
// The |CertStore| provides all X509Certificates.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698