Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Side by Side Diff: chrome/browser/website_settings.h

Issue 10181004: Add comment to explain why some of the strings are typed as string16, and a TODO as a reminder to c… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_WEBSITE_SETTINGS_H_ 5 #ifndef CHROME_BROWSER_WEBSITE_SETTINGS_H_
6 #define CHROME_BROWSER_WEBSITE_SETTINGS_H_ 6 #define CHROME_BROWSER_WEBSITE_SETTINGS_H_
7 7
8 #include "base/string16.h" 8 #include "base/string16.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "chrome/browser/content_settings/tab_specific_content_settings.h" 10 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 // The Omnibox URL of the website for which to display site permissions and 140 // The Omnibox URL of the website for which to display site permissions and
141 // site information. 141 // site information.
142 GURL site_url_; 142 GURL site_url_;
143 143
144 // Status of the website's identity verification check. 144 // Status of the website's identity verification check.
145 SiteIdentityStatus site_identity_status_; 145 SiteIdentityStatus site_identity_status_;
146 146
147 // Status of the connection to the website. 147 // Status of the connection to the website.
148 SiteConnectionStatus site_connection_status_; 148 SiteConnectionStatus site_connection_status_;
149 149
150 // TODO(markusheintz): Move the creation of all the string16 typed UI
151 // strings below to the corresponding UI code, in order to prevent
152 // unnesseccary UTF string conversions.
wtc 2012/04/23 21:49:30 Typo: unnesseccary => unnecessary Should this be
markusheintz_ 2012/04/24 08:52:59 Done.
153
150 // Details about the website's identity. If the website's identity has been 154 // Details about the website's identity. If the website's identity has been
151 // verified then |site_identity_details_| contains who verified the identity. 155 // verified then |site_identity_details_| contains who verified the identity.
156 // This string will be displayed in the UI.
152 string16 site_identity_details_; 157 string16 site_identity_details_;
153 158
154 // Details about the connection to the website. In case of an encrypted 159 // Details about the connection to the website. In case of an encrypted
155 // connection |site_connection_details_| contains encryption details, like 160 // connection |site_connection_details_| contains encryption details, like
156 // encryption strength and ssl protocol version. 161 // encryption strength and ssl protocol version. This string will be
162 // displayed in the UI.
157 string16 site_connection_details_; 163 string16 site_connection_details_;
158 164
159 // For websites that provided an EV certificate |orgainization_name_| contains 165 // For websites that provided an EV certificate |orgainization_name_|
160 // the organization name of the certificate. In all other cases 166 // contains the organization name of the certificate. In all other cases
161 // |organization_name| is an empty string. 167 // |organization_name| is an empty string. This string will be displayed in
168 // the UI.
162 string16 organization_name_; 169 string16 organization_name_;
163 170
164 // The |CertStore| provides all X509Certificates. 171 // The |CertStore| provides all X509Certificates.
165 content::CertStore* cert_store_; 172 content::CertStore* cert_store_;
166 173
167 // The |HostContentSettingsMap| is the service that provides and manages 174 // The |HostContentSettingsMap| is the service that provides and manages
168 // content settings (aka. site permissions). 175 // content settings (aka. site permissions).
169 HostContentSettingsMap* content_settings_; 176 HostContentSettingsMap* content_settings_;
170 177
171 DISALLOW_COPY_AND_ASSIGN(WebsiteSettings); 178 DISALLOW_COPY_AND_ASSIGN(WebsiteSettings);
172 }; 179 };
173 180
174 #endif // CHROME_BROWSER_WEBSITE_SETTINGS_H_ 181 #endif // CHROME_BROWSER_WEBSITE_SETTINGS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698