Add comment to explain why some of the strings are typed as string16, and a TODO as a reminder to c…

Add comment to explain why some of the strings are typed as string16, and a TODO as a reminder to change this down the road.


BUG=113688
TEST=none

[markusheintz_, 2012-04-23 15:15:38]

This is a followup to https://chromiumcodereview.appspot.com/10169004/

Since I used some of the original |PageInfoBubble| code as basis for the
|WebsiteSettings| class, some of the strings are of type string16. All these
strings are displayed in the UI.

Using string16 causes some unnecessary UTF string conversions for the GTK UI
(same problem as in the existing |PageInfoBubble|.

This will be changed soon.

If you like then this CL adds a TODO as a reminder.

[Finnur, 2012-04-23 15:26:02]

LGTM

[wtc, 2012-04-23 21:49:30]

LGTM.

https://chromiumcodereview.appspot.com/10181004/diff/1/chrome/browser/website...
File chrome/browser/website_settings.h (right):

https://chromiumcodereview.appspot.com/10181004/diff/1/chrome/browser/website...
chrome/browser/website_settings.h:152: // unnesseccary UTF string conversions.

Typo: unnesseccary => unnecessary

Should this be "UTF-8 string conversions"?

[markusheintz_, 2012-04-24 08:52:59]

https://chromiumcodereview.appspot.com/10181004/diff/1/chrome/browser/website...
File chrome/browser/website_settings.h (right):

https://chromiumcodereview.appspot.com/10181004/diff/1/chrome/browser/website...
chrome/browser/website_settings.h:152: // unnesseccary UTF string conversions.
On 2012/04/23 21:49:30, wtc wrote:
> 
> Typo: unnesseccary => unnecessary
> 
> Should this be "UTF-8 string conversions"?

Done.

[wtc, 2012-04-24 18:20:14]

lgtm

Patch set 2 LGTM.  Thanks!

In the future you can commit without waiting for my second
review.