Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

Issue 1017883002: [App banners] Add browser test for canceling banners (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/test/data/banners/cancel_test_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc b/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
index 8ad661b1abd0d4779af256e60abe93ffbcbe4253..5beb9b33d2252d8396f149c3ade4acff73ecfc3c 100644
--- a/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/banners/app_banner_data_fetcher.h"
+#include "base/command_line.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/task_runner.h"
@@ -11,6 +12,7 @@
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/common/content_switches.h"
#include "content/public/test/test_navigation_observer.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
@@ -67,6 +69,11 @@ class AppBannerDataFetcherBrowserTest : public InProcessBrowserTest,
return false;
}
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ command_line->AppendSwitch(
+ switches::kEnableExperimentalWebPlatformFeatures);
+ }
+
protected:
void RunFetcher(const GURL& url,
bool expected_manifest_valid,
@@ -134,4 +141,19 @@ IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, NoManifest) {
RunFetcher(web_contents->GetURL(), false, false);
}
+IN_PROC_BROWSER_TEST_F(AppBannerDataFetcherBrowserTest, CancelBanner) {
+ std::string valid_page = "/banners/cancel_test_page.html";
+ GURL test_url = embedded_test_server()->GetURL(valid_page);
+ content::WebContents* web_contents =
+ browser()->tab_strip_model()->GetActiveWebContents();
+
+ LoadURLAndWaitForServiceWorker(test_url);
+ RunFetcher(web_contents->GetURL(), true, false);
+
+ // Advance by a day, then visit the page again. Still shouldn't see a banner.
+ AppBannerDataFetcher::SetTimeDeltaForTesting(1);
+ LoadURLAndWaitForServiceWorker(test_url);
+ RunFetcher(web_contents->GetURL(), true, false);
+}
+
} // namespace banners
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/test/data/banners/cancel_test_page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698