Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4858)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.cc

Issue 1017883002: [App banners] Add browser test for canceling banners (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher.cc b/chrome/browser/banners/app_banner_data_fetcher.cc
index 587f61a8f38e82b815483b12cd0f9b20f1446e73..66faab4c2215a56acce6f8292e1c4c964ade8acc 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher.cc
@@ -140,7 +140,6 @@ void AppBannerDataFetcher::OnBannerPromptReply(
Cancel();
return;
}
- is_active_ = false;
// The renderer might have requested the prompt to be canceled.
if (reply == blink::WebAppBannerPromptReply::Cancel) {
@@ -159,6 +158,7 @@ void AppBannerDataFetcher::OnBannerPromptReply(
InfoBarService::FromWebContents(web_contents)->AddInfoBar(
make_scoped_ptr(infobar));
}
+ is_active_ = false;
}
AppBannerDataFetcher::~AppBannerDataFetcher() {

Powered by Google App Engine
This is Rietveld 408576698