Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: sandbox/linux/seccomp-bpf/sandbox_bpf.h

Issue 101773003: Linux sandbox: cleanup sandbox-bpf naming. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename class Sandbox to class SandboxBPF Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/linux/seccomp-bpf/sandbox_bpf.h
diff --git a/sandbox/linux/seccomp-bpf/sandbox_bpf.h b/sandbox/linux/seccomp-bpf/sandbox_bpf.h
index fef50988b3cd295da29c59ce4f8d25cc164ccc33..6c2a0d8e278814b1fa1e53292a891a3e2fe5bea9 100644
--- a/sandbox/linux/seccomp-bpf/sandbox_bpf.h
+++ b/sandbox/linux/seccomp-bpf/sandbox_bpf.h
@@ -21,7 +21,7 @@
#include "sandbox/linux/seccomp-bpf/errorcode.h"
#include "sandbox/linux/seccomp-bpf/linux_seccomp.h"
-namespace playground2 {
+namespace sandbox {
struct arch_seccomp_data {
int nr;
@@ -41,7 +41,7 @@ class SandboxUnittestHelper;
class SandboxBpfPolicy;
struct Instruction;
-class Sandbox {
+class SandboxBPF {
Robert Sesek 2013/12/10 15:07:46 So we have SandboxBPF and SandboxBpfPolicy. We sho
jln (very slow on Chromium) 2013/12/10 18:43:47 I've been through the whole codebase and capitaliz
public:
enum SandboxStatus {
STATUS_UNKNOWN, // Status prior to calling supportsSeccompSandbox()
@@ -56,7 +56,7 @@ class Sandbox {
// policy each time a call is made through an EvaluateSyscall function
// pointer. One common use case would be to pass the "aux" pointer as an
// argument to Trap() functions.
- typedef ErrorCode (*EvaluateSyscall)(Sandbox* sandbox_compiler,
+ typedef ErrorCode (*EvaluateSyscall)(SandboxBPF* sandbox_compiler,
int system_call_number,
void* aux);
typedef std::vector<std::pair<EvaluateSyscall, void*> > Evaluators;
@@ -74,8 +74,8 @@ class Sandbox {
// should be noted that during its lifetime, the object probably made
// irreversible state changes to the runtime environment. These changes
// stay in effect even after the destructor has been run.
- Sandbox();
- ~Sandbox();
+ SandboxBPF();
+ ~SandboxBPF();
// Checks whether a particular system call number is valid on the current
// architecture. E.g. on ARM there's a non-contiguous range of private
@@ -268,7 +268,7 @@ class Sandbox {
Conds* conds_;
bool sandbox_has_started_;
- DISALLOW_COPY_AND_ASSIGN(Sandbox);
+ DISALLOW_COPY_AND_ASSIGN(SandboxBPF);
};
} // namespace

Powered by Google App Engine
This is Rietveld 408576698