Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 101773003: Linux sandbox: cleanup sandbox-bpf naming. (Closed)

Created:
7 years ago by jln (very slow on Chromium)
Modified:
7 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Linux sandbox: cleanup sandbox-bpf naming. 1. Rename playground2 namespace to sandbox. The playground2 namespace is confusing and against the style guide. We rename it to sandbox, like the rest of sandbox/linux/. 2. Rename the "Sandbox" class to "SandboxBPF". BUG=325535 R=rsesek@chromium.org TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239865

Patch Set 1 #

Patch Set 2 : Rename class Sandbox to class SandboxBPF #

Total comments: 22

Patch Set 3 : Rebase #

Patch Set 4 : Address nits. #

Total comments: 18

Patch Set 5 : Address nits. #

Total comments: 16

Patch Set 6 : Address namespace sandbox nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -430 lines) Patch
M chrome/browser/ui/webui/about_ui.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/security_tests/sandbox_browsertest_linux.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nacl_helper_linux.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nacl_sandbox_linux.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nacl_sandbox_linux.cc View 1 2 3 3 chunks +14 lines, -14 lines 0 comments Download
M content/common/sandbox_bpf_base_policy_linux.h View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M content/common/sandbox_bpf_base_policy_linux.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/sandbox_init_linux.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/sandbox_linux.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux.cc View 1 2 3 4 chunks +8 lines, -8 lines 0 comments Download
M content/common/sandbox_seccomp_bpf_linux.h View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M content/common/sandbox_seccomp_bpf_linux.cc View 1 2 3 25 chunks +56 lines, -55 lines 0 comments Download
M content/public/common/sandbox_init.h View 1 2 3 2 chunks +4 lines, -7 lines 0 comments Download
M content/public/common/sandbox_linux.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_linux.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.h View 1 2 3 2 chunks +7 lines, -13 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h View 1 chunk +2 lines, -6 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h View 1 1 chunk +10 lines, -15 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 1 8 chunks +7 lines, -11 lines 0 comments Download
M sandbox/linux/seccomp-bpf/basicblock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/basicblock.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tests.h View 1 2 3 4 5 5 chunks +22 lines, -22 lines 0 comments Download
M sandbox/linux/seccomp-bpf/codegen.h View 1 2 3 4 5 7 chunks +7 lines, -7 lines 0 comments Download
M sandbox/linux/seccomp-bpf/codegen.cc View 1 2 3 4 5 6 chunks +8 lines, -8 lines 0 comments Download
M sandbox/linux/seccomp-bpf/codegen_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sandbox/linux/seccomp-bpf/demo.cc View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M sandbox/linux/seccomp-bpf/die.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M sandbox/linux/seccomp-bpf/die.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/errorcode.h View 1 2 3 4 5 5 chunks +5 lines, -5 lines 0 comments Download
M sandbox/linux/seccomp-bpf/errorcode.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/errorcode_unittest.cc View 1 2 3 5 chunks +7 lines, -5 lines 0 comments Download
M sandbox/linux/seccomp-bpf/instruction.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.h View 1 2 3 4 7 chunks +11 lines, -11 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 1 2 3 4 23 chunks +53 lines, -53 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf_policy.h View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc View 1 2 3 54 chunks +89 lines, -88 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_iterator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_iterator.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_iterator_unittest.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_unittest.cc View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/trap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/trap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/verifier.h View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M sandbox/linux/seccomp-bpf/verifier.cc View 1 2 3 5 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jln (very slow on Chromium)
Robert, another cleanup CL. This is mostly a mechanical search and replace of "playground2" to ...
7 years ago (2013-12-10 00:40:18 UTC) #1
jln (very slow on Chromium)
On 2013/12/10 00:40:18, jln wrote: > Robert, another cleanup CL. This is mostly a mechanical ...
7 years ago (2013-12-10 02:06:39 UTC) #2
Robert Sesek
https://chromiumcodereview.appspot.com/101773003/diff/40001/content/common/sandbox_seccomp_bpf_linux.cc File content/common/sandbox_seccomp_bpf_linux.cc (right): https://chromiumcodereview.appspot.com/101773003/diff/40001/content/common/sandbox_seccomp_bpf_linux.cc#newcode51 content/common/sandbox_seccomp_bpf_linux.cc:51: using sandbox::SandboxBPF; nit: alphabetize https://chromiumcodereview.appspot.com/101773003/diff/40001/sandbox/linux/seccomp-bpf/errorcode_unittest.cc File sandbox/linux/seccomp-bpf/errorcode_unittest.cc (right): https://chromiumcodereview.appspot.com/101773003/diff/40001/sandbox/linux/seccomp-bpf/errorcode_unittest.cc#newcode83 ...
7 years ago (2013-12-10 15:07:45 UTC) #3
jln (very slow on Chromium)
Thanks for the careful review Robert. PTAL! https://chromiumcodereview.appspot.com/101773003/diff/40001/content/common/sandbox_seccomp_bpf_linux.cc File content/common/sandbox_seccomp_bpf_linux.cc (right): https://chromiumcodereview.appspot.com/101773003/diff/40001/content/common/sandbox_seccomp_bpf_linux.cc#newcode51 content/common/sandbox_seccomp_bpf_linux.cc:51: using sandbox::SandboxBPF; ...
7 years ago (2013-12-10 18:43:47 UTC) #4
Robert Sesek
Just nits https://chromiumcodereview.appspot.com/101773003/diff/100001/content/common/sandbox_seccomp_bpf_linux.cc File content/common/sandbox_seccomp_bpf_linux.cc (right): https://chromiumcodereview.appspot.com/101773003/diff/100001/content/common/sandbox_seccomp_bpf_linux.cc#newcode54 content/common/sandbox_seccomp_bpf_linux.cc:54: using sandbox::arch_seccomp_data; nit: alphabetize https://chromiumcodereview.appspot.com/101773003/diff/100001/sandbox/linux/seccomp-bpf/instruction.h File sandbox/linux/seccomp-bpf/instruction.h ...
7 years ago (2013-12-10 21:15:26 UTC) #5
jln (very slow on Chromium)
https://chromiumcodereview.appspot.com/101773003/diff/100001/content/common/sandbox_seccomp_bpf_linux.cc File content/common/sandbox_seccomp_bpf_linux.cc (right): https://chromiumcodereview.appspot.com/101773003/diff/100001/content/common/sandbox_seccomp_bpf_linux.cc#newcode54 content/common/sandbox_seccomp_bpf_linux.cc:54: using sandbox::arch_seccomp_data; On 2013/12/10 21:15:26, rsesek wrote: > nit: ...
7 years ago (2013-12-10 21:36:38 UTC) #6
Robert Sesek
LGTM w/ nits Looks like I only started noticing the missing "namespace sandbox" in the ...
7 years ago (2013-12-10 21:52:04 UTC) #7
jln (very slow on Chromium)
Thanks! I'm very glad we're finally cleaning up this stuff! https://chromiumcodereview.appspot.com/101773003/diff/120001/sandbox/linux/seccomp-bpf/basicblock.cc File sandbox/linux/seccomp-bpf/basicblock.cc (right): https://chromiumcodereview.appspot.com/101773003/diff/120001/sandbox/linux/seccomp-bpf/basicblock.cc#newcode13 ...
7 years ago (2013-12-10 22:01:47 UTC) #8
jln (very slow on Chromium)
Jochen: TBR for content/ and /chrome: just renaming stuff.
7 years ago (2013-12-10 22:05:47 UTC) #9
jln (very slow on Chromium)
7 years ago (2013-12-10 22:19:29 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 manually as r239865 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698